[Reporting/FieldFormats] expose setFieldFormats and call from ReportingPlugin.start#56563
Merged
tsullivan merged 7 commits intoelastic:masterfrom Feb 3, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
af1652b to
d6e2630
Compare
d6e2630 to
9b048e4
Compare
lizozom
approved these changes
Feb 2, 2020
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Haven't pulled to test, but looks LGTM
Added a couple of minor comments.
| const coreSetup = server.newPlatform.setup.core; | ||
| const pluginInstance = plugin(server.newPlatform.coreContext as PluginInitializerContext); | ||
|
|
||
| await pluginInstance.setup(coreSetup, { |
Contributor
There was a problem hiding this comment.
Do you have to await the result of setup?
The next stage awaits on the results of getStartServices anyway.
Member
Author
There was a problem hiding this comment.
I do need a way to make sure that my plugin's start method would not be called before setup.
Soon in the plugin class there will be a private field referenced in setup and start, so I'd have a race condition if start was using the data before it is initialized in setup.
I don't have my mind settled yet on how to co-ordinate dependencies in setup and start, but I plan to have it outlined in an upcoming PR to provide more plugin dependencies to modules that aren't called from routes handlers. :)
| @@ -68,35 +61,7 @@ export const reporting = (kibana: any) => { | |||
| }, | |||
|
|
|||
| async init(server: Legacy.Server) { | |||
Contributor
There was a problem hiding this comment.
I don't think this has to be async anymore
7 tasks
alexwizp
approved these changes
Feb 3, 2020
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Feb 4, 2020
* master: (42 commits) Move kuery_autocomplete ⇒ NP (elastic#56607) [ML] Functional tests - stabilize job row and analytics result view assertions (elastic#56595) [Discover] Inline angular directives only used in this plugin (elastic#56119) [Discover] Migrate get_sort.js test from mocha to TypeScript (elastic#56011) [SIEM] Enable flow_target_select_connected unit tests (elastic#55618) Start consuming np logging config (elastic#56480) [SIEM] Add eslint-plugin-react-perf (elastic#55960) Mention changed SAML ACS endpoint URL in breaking changes doc. (elastic#56613) Add `getServerInfo` API to http setup contract (elastic#56636) Updates Monitoring alert Jest snapshots Kibana property config migrations (elastic#55937) Vislib replacement toggle (elastic#56439) [Uptime] Add unit tests for QueryContext time calculation (elastic#56671) [SIEM][Detection Engine] Critical blocker, fixes pre-packaged rule miscounts Upgrade EUI to v18.3.0 (elastic#56228) [Maps] Fix server log (elastic#56679) [SIEM] Fixes FTUE when APM node is present (elastic#56574) [Reporting/FieldFormats] expose `setFieldFormats` and call from ReportingPlugin.start (elastic#56563) Update EMS API urls for production (elastic#56657) Ability to delete alerts even when AAD is out of sync (elastic#56543) ...
tsullivan
added a commit
to tsullivan/kibana
that referenced
this pull request
Feb 5, 2020
…tingPlugin.start (elastic#56563) * [Reporting] New Platform Migration Part of elastic#53898 * fix CI * fix typescript Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Feb 5, 2020
…tingPlugin.start (#56563) (#56875) * [Reporting] New Platform Migration Part of #53898 * fix CI * fix typescript Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces:
This PR cleans up a problem where a "start" plugin had to be grabbed before ReportingPlugin.setup was called, so it organizes the code better for future "start" plugin migrations.
Replaces #56485
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.[ ] This was checked for cross-browser compatibility, including a check against IE11[ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support[ ] Documentation was added for features that require explanation or tutorials[ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
[ ] This includes a feature addition or change that requires a release note and was labeled appropriately