Remove the editor config provider registry#56501
Merged
sulemanof merged 5 commits intoelastic:masterfrom Feb 5, 2020
Merged
Conversation
flash1293
reviewed
Jan 31, 2020
|
|
||
| export interface TypeMeta { | ||
| aggs?: Record<string, AggregationRestrictions>; | ||
| params?: { |
Contributor
There was a problem hiding this comment.
you can make that even softer and allow
export interface TypeMeta {
aggs?: Record<string, AggregationRestrictions>;
[key: string]: any;
}It's not the case for current usages, but theoretically a plugin could put other stuff in here
7 tasks
Contributor
Author
|
@elasticmachine merge upstream |
flash1293
approved these changes
Feb 3, 2020
Contributor
flash1293
left a comment
There was a problem hiding this comment.
LGTM, tested and restrictions work as expected in editor
lukeelmers
approved these changes
Feb 4, 2020
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
…fig_provider # Conflicts: # src/legacy/core_plugins/vis_default_editor/public/components/agg_param_props.ts # src/legacy/core_plugins/vis_default_editor/public/components/agg_params.tsx # src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.test.ts # src/legacy/core_plugins/vis_default_editor/public/components/agg_params_helper.ts # src/legacy/core_plugins/vis_default_editor/public/components/controls/test_utils.ts # src/legacy/ui/public/vis/config/editor_config_providers.test.ts # src/legacy/ui/public/vis/config/editor_config_providers.ts # x-pack/legacy/plugins/rollup/public/legacy.ts # x-pack/legacy/plugins/rollup/public/legacy_imports.ts
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
sulemanof
added a commit
that referenced
this pull request
Feb 5, 2020
* Remove the editor_config_providers * Remove unused translations * Fix eslint errors Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> # Conflicts: # src/plugins/data/public/index_patterns/index_patterns/index_pattern.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes the
editorConfigProviderswhich was only working for rollup indexes.Instead, the
getAggregationRestrictionswas created in theindexPatterninstance to retrieve those restrictions without relying on therollupindex type.Also resolves #55970.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers