[Uptime] Fix flaky functional test for #54541#56449
Merged
justinkambic merged 4 commits intoelastic:masterfrom Feb 3, 2020
Merged
[Uptime] Fix flaky functional test for #54541#56449justinkambic merged 4 commits intoelastic:masterfrom
justinkambic merged 4 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/uptime (Team:uptime) |
shahzad31
approved these changes
Jan 31, 2020
Contributor
shahzad31
left a comment
There was a problem hiding this comment.
@elasticmachine merge upstream
LGTM, maybe let's try CI for couple of times
Contributor
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
This was referenced Feb 3, 2020
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Feb 3, 2020
* Add timeout block to race-prone functional test code. * Add timeout for pagination click functions. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Feb 3, 2020
* Add timeout block to race-prone functional test code. * Add timeout for pagination click functions. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Feb 3, 2020
* Add timeout block to race-prone functional test code. * Add timeout for pagination click functions. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
justinkambic
added a commit
that referenced
this pull request
Feb 3, 2020
* Add timeout block to race-prone functional test code. * Add timeout for pagination click functions. Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Contributor
Author
|
Backported to: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #54541.
Attempting to make a functional test more reliable.
First de-flake verification attempt: https://kibana-ci.elastic.co/job/kibana+flaky-test-suite-runner/157/