[Maps] Autocomplete for custom color palettes and custom icon palettes by nreese · Pull Request #56446 · elastic/kibana

nreese · 2020-01-30T21:31:57Z

fixes #54921 and #56049

…on maps

elasticmachine · 2020-01-30T21:32:00Z

Pinging @elastic/kibana-gis (Team:Geo)

nreese · 2020-01-31T13:22:48Z

@elasticmachine merge upstream

…category_suggestions

nreese · 2020-02-03T13:44:12Z

@elasticmachine merge upstream

jsanz

Tested in Firefox and Chromium and working nicely, this is great 👍

thomasneirynck

Some small comments.

I would either disable auto-complete for IPs/boolean-fields, or try and have some custom best-effort (e.g booleans could be do-able on Maps-side).

x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/dynamic_style_property.js

x-pack/legacy/plugins/maps/public/layers/sources/es_source.js

x-pack/legacy/plugins/maps/public/layers/styles/vector/components/stop_input.js

…estions

nreese · 2020-02-12T13:12:41Z

@elasticmachine merge upstream

thomasneirynck

Really cool addition.

I think there's a small bug when dealing with a field-selection change.

Steps:

select a string-field in by-value styling
select "custom palette" and enter some stop values using the auto-complete
select a different string-field
use drop-down to modify existing value in a stop (or add new stop and use drop-down)
-> the auto-complete shows options from the field selected in (1)
(typing in to trigger a new "suggestion-load" will start showing correct suggestions).

…estions

…category_suggestions

nreese · 2020-02-12T19:37:20Z

I think there's a small bug when dealing with a field-selection change.

Thanks for pointing this out. I have pushed a fix. I found this article about using key to force new component instance in cases like this. That way, when the field changes, a new component instance is created so there is no lingering state to cleanup/ keep track of.

I think we should use this pattern in other places where we rely on componentDidUpdate to change state if some prop changes.

thomasneirynck · 2020-02-12T20:26:43Z

.../legacy/plugins/maps/public/layers/styles/vector/components/color/color_stops_categorical.js


    return (
      <StopInput
+        key={field.getName()} // force new component instance when field changes


this is really clever

kibanamachine · 2020-02-12T21:11:55Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6bf86a3

History

💚 Build #26293 succeeded b02dbab
💚 Build #26167 succeeded 85b30b5
💚 Build #25438 succeeded c03cb7c
💚 Build #24175 succeeded fddacdb
💚 Build #23998 succeeded 6154143

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

elastic#56446) * [Maps] type ahead for stop values for custom color maps and custom icon maps * use Popover to show type ahead suggestions * datalist version * use EuiComboBox * clean up * wire ColorStopsCategorical to use StopInput component for autocomplete * clean up * cast suggestion values to string so boolean fields work * review feedback * fix problem with stall suggestions from previous field Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

#56446) (#57504) * [Maps] type ahead for stop values for custom color maps and custom icon maps * use Popover to show type ahead suggestions * datalist version * use EuiComboBox * clean up * wire ColorStopsCategorical to use StopInput component for autocomplete * clean up * cast suggestion values to string so boolean fields work * review feedback * fix problem with stall suggestions from previous field Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…ibana into backport/7.x/pr-57404 * 'backport/7.x/pr-57404' of https://github.com/gmmorris/kibana: [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) (elastic#57504) Add "coerce" to dev tools autocomplete (elastic#56862) (elastic#57498) [DOCS] Fixes typo in release highlights (elastic#57487)

* master: (22 commits) Use log4j pattern syntax (elastic#57433) [ML] Categorization field example endpoint tests (elastic#57471) [Lens] Filter out pinned filters from saved object of Lens (elastic#57197) Lens client side shim cleanup (elastic#56976) [Maps] do not show border color for icon in legend when border width is zero (elastic#57501) refactors 'data-providers' tests (elastic#57474) add `absolute` option to `getUrlForApp` (elastic#57193) [Telemetry] Migrate public to NP (elastic#56285) address flaky test where instances might have different start… (elastic#57506) fix(NA): support legacy plugins path in plugins (elastic#57472) build immutable bundles for new platform plugins (elastic#53976) [SIEM] [Detection Engine] Reject if duplicate rule_id in request payload (elastic#57057) Add autocomplete="off" for input type="password" to appease the scanners (elastic#56922) Use default spaces suffix for signals index if spaces disabled (elastic#57244) [Alerting] Create alert design cleanup (elastic#56929) Management Api - add to migration guide (elastic#56892) fixing maps (elastic#56706) [Maps] Autocomplete for custom color palettes and custom icon palettes (elastic#56446) [Alerting] make actionGroup name's i18n-able (elastic#57404) fixed flaky test (elastic#57490) ... # Conflicts: # src/legacy/core_plugins/telemetry/public/components/__snapshots__/telemetry_form.test.js.snap # src/plugins/telemetry/public/components/telemetry_management_section.tsx

nreese added 4 commits January 29, 2020 16:53

[Maps] type ahead for stop values for custom color maps and custom ic…

212b9b7

…on maps

use Popover to show type ahead suggestions

0daf0a9

datalist version

b3c8aaa

use EuiComboBox

3bda35f

nreese added release_note:enhancement WIP Work in progress Team:Geo Former Team Label for Geo Team. Now use Team:Presentation v8.0.0 v7.7.0 labels Jan 30, 2020

nreese requested a review from a team as a code owner January 30, 2020 21:31

nreese added 2 commits January 30, 2020 16:36

clean up

2bb25ec

wire ColorStopsCategorical to use StopInput component for autocomplete

6e44f0c

nreese requested a review from thomasneirynck January 31, 2020 13:22

nreese removed the WIP Work in progress label Jan 31, 2020

elasticmachine and others added 3 commits January 31, 2020 08:22

Merge branch 'master' into category_suggestions

2f43e77

clean up

cf8526e

Merge branch 'category_suggestions' of github.com:nreese/kibana into …

9ae2fa4

…category_suggestions

Merge branch 'master' into category_suggestions

6154143

jsanz approved these changes Feb 3, 2020

View reviewed changes

thomasneirynck reviewed Feb 3, 2020

View reviewed changes

nreese added 3 commits February 3, 2020 17:34

cast suggestion values to string so boolean fields work

fddacdb

Merge branch 'master' of github.com:elastic/kibana into category_sugg…

c1096bf

…estions

review feedback

c03cb7c

nreese requested a review from thomasneirynck February 9, 2020 12:52

Merge branch 'master' into category_suggestions

85b30b5

thomasneirynck reviewed Feb 12, 2020

View reviewed changes

nreese added 3 commits February 12, 2020 12:25

Merge branch 'master' of github.com:elastic/kibana into category_sugg…

fba491a

…estions

Merge branch 'category_suggestions' of github.com:nreese/kibana into …

b02dbab

…category_suggestions

fix problem with stall suggestions from previous field

6bf86a3

nreese requested a review from thomasneirynck February 12, 2020 19:37

thomasneirynck approved these changes Feb 12, 2020

View reviewed changes

nreese merged commit be7daa8 into elastic:master Feb 12, 2020

nreese mentioned this pull request Feb 12, 2020

[7.x] [Maps] Autocomplete for custom color palettes and custom icon palettes (#56446) #57504

Merged

thomasneirynck mentioned this pull request Mar 26, 2020

[Maps] Typing in custom color maps is slow #56049

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Maps] Autocomplete for custom color palettes and custom icon palettes#56446

[Maps] Autocomplete for custom color palettes and custom icon palettes#56446
nreese merged 17 commits intoelastic:masterfrom
nreese:category_suggestions

nreese commented Jan 30, 2020 •

edited

Loading

Uh oh!

elasticmachine commented Jan 30, 2020

Uh oh!

nreese commented Jan 31, 2020

Uh oh!

nreese commented Feb 3, 2020

Uh oh!

jsanz left a comment

Uh oh!

thomasneirynck left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese commented Feb 12, 2020

Uh oh!

thomasneirynck left a comment

Uh oh!

nreese commented Feb 12, 2020 •

edited

Loading

Uh oh!

thomasneirynck Feb 12, 2020

Uh oh!

kibanamachine commented Feb 12, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

nreese commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elasticmachine commented Jan 30, 2020

Uh oh!

nreese commented Jan 31, 2020

Uh oh!

nreese commented Feb 3, 2020

Uh oh!

jsanz left a comment

Choose a reason for hiding this comment

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

nreese commented Feb 12, 2020

Uh oh!

thomasneirynck left a comment

Choose a reason for hiding this comment

Uh oh!

nreese commented Feb 12, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

thomasneirynck Feb 12, 2020

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 12, 2020

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

nreese commented Jan 30, 2020 •

edited

Loading

nreese commented Feb 12, 2020 •

edited

Loading