[NP] Move saved object modal into new platform by maryia-lapata · Pull Request #56383 · elastic/kibana

maryia-lapata · 2020-01-30T13:49:15Z

The functionality around the save modal for saved objects was moved into a new NP plugin saved_objects:

src/legacy/ui/public/saved_objects/components/saved_object_save_modal.tsx was removed;
src/plugins/kibana_react/public/saved_objects and src/legacy/ui/public/saved_objects/show_saved_object_save_modal.tsx were moved into new plugin src/plgins/saved_objects.

Dev Docs

SavedObjectSaveModal, showSaveModal and SaveResult from ui/saved_objects, and SavedObjectFinderUi, SavedObjectMetaData and OnSaveProps from src/plugins/kibana_react/public were moved to a new plugin src/plugins/saved_objects.

Also now showSaveModal requires the second argument - I18nContext:

import { showSaveModal } from 'src/plugins/saved_objects/public';
...

showSaveModal(saveModal, npStart.core.i18n.Context);

# Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

This reverts commit f2f9f5e.

This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

# Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx

maryia-lapata · 2020-02-03T12:53:01Z

src/plugins/saved_objects/public/saved_object_finder.tsx

-import { useKibana } from '../context';
-
-// TODO the typings for EuiListGroup are incorrect - maxWidth is missing. This can be removed when the types are adjusted
-const FixedEuiListGroup = (EuiListGroup as any) as React.FunctionComponent<


EuiListGroup already contains maxWidth, so, I think, we can remove the wrapper FixedEuiListGroup.

maryia-lapata · 2020-02-03T12:56:42Z

src/plugins/saved_objects/public/_index.scss

@@ -0,0 +1 @@
+@import './save_modal';


@flash1293 I don't see that the styles from src/plugins/saved_objects are imported automatically. Maybe do you know how I can load them?

@flash1293 Should be able to help with adding this file to the SASS compiler, but currently this line is wrong. There is no save_modal.scss file in this folder. The import needs to point to the index file within that folder instead.

Suggested change

@import './save_modal';

@import './save_modal/index';

@cchaos Nice catch! thanks.
Since styles can't move to the new platform at the moment, I left its import in ui/saved_objects for now.

peteharverson

ML edit LGTM

flash1293

LGTM once green. Can you add a dev doc section about the updated paths to import those?

maryia-lapata · 2020-02-05T06:50:40Z

@elasticmachine merge upstream

lizozom

Tested and overall LGTM.
Added a couple of structural comments.

src/plugins/saved_objects/public/saved_object_finder.tsx

src/plugins/saved_objects/public/index.ts

crob611

Canvas changes look good 👍 Nice work on this

# Conflicts: # src/legacy/core_plugins/visualizations/public/np_ready/public/wizard/search_selection/search_selection.tsx

kibanamachine · 2020-02-06T16:19:50Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 0cf3fc8

History

💚 Build #24565 succeeded f1faec4
💚 Build #24518 succeeded ec3d6a7
💚 Build #24255 succeeded 8c883c0
💔 Build #24249 failed 3507f21
💚 Build #24052 succeeded b2855df

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Move saved object modal into new platform * Fix TS * Revert "Fix TS" This reverts commit f2f9f5e. * Revert "Move saved object modal into new platform" This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js * Move save_object_save_modal * Move show_saved_object_save_modal.tsx * Move save_object_finder.tsx * Remove unused export * Pass I18nContext to showSaveModal * Update i18n ids * Fix map save * Refactoring * Load styles * Revert importing styles * Update snapshot * Update snapshot * Structural refactoring * Fix path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

elasticmachine · 2020-02-10T08:40:25Z

Pinging @elastic/kibana-app (Team:KibanaApp)

* Move saved object modal into new platform * Fix TS * Revert "Fix TS" This reverts commit f2f9f5e. * Revert "Move saved object modal into new platform" This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js * Move save_object_save_modal * Move show_saved_object_save_modal.tsx * Move save_object_finder.tsx * Remove unused export * Pass I18nContext to showSaveModal * Update i18n ids * Fix map save * Refactoring * Load styles * Revert importing styles * Update snapshot * Update snapshot * Structural refactoring * Fix path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…56428) * [Add panel flyout] Moving create new to the top of SavedObjectFinder * [Add panel flyout] Moving create new to the top of SavedObjectFinder * Fixing failing unit test * Readd missing test * [NP] Move saved object modal into new platform (#56383) * Move saved object modal into new platform * Fix TS * Revert "Fix TS" This reverts commit f2f9f5e. * Revert "Move saved object modal into new platform" This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js * Move save_object_save_modal * Move show_saved_object_save_modal.tsx * Move save_object_finder.tsx * Remove unused export * Pass I18nContext to showSaveModal * Update i18n ids * Fix map save * Refactoring * Load styles * Revert importing styles * Update snapshot * Update snapshot * Structural refactoring * Fix path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Applying PR comments Removing faulty rebase imports Fixing unresolved conflict Removing faulty merge files Removing faulty import Readd accidentally added file * Removing unnecessary eslint-ignore Co-authored-by: Maryia Lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

…56428) (#57360) * [Add panel flyout] Moving create new to the top of SavedObjectFinder * [Add panel flyout] Moving create new to the top of SavedObjectFinder * Fixing failing unit test * Readd missing test * [NP] Move saved object modal into new platform (#56383) * Move saved object modal into new platform * Fix TS * Revert "Fix TS" This reverts commit f2f9f5e. * Revert "Move saved object modal into new platform" This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js * Move save_object_save_modal * Move show_saved_object_save_modal.tsx * Move save_object_finder.tsx * Remove unused export * Pass I18nContext to showSaveModal * Update i18n ids * Fix map save * Refactoring * Load styles * Revert importing styles * Update snapshot * Update snapshot * Structural refactoring * Fix path Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Applying PR comments Removing faulty rebase imports Fixing unresolved conflict Removing faulty merge files Removing faulty import Readd accidentally added file * Removing unnecessary eslint-ignore Co-authored-by: Maryia Lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Maryia Lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>

maryia-lapata added 8 commits January 29, 2020 17:44

Move saved object modal into new platform

d0f0ea6

Merge remote-tracking branch 'kibana/master' into save-object-modal

3b49800

# Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

Fix TS

f2f9f5e

Revert "Fix TS"

26f1398

This reverts commit f2f9f5e.

Revert "Move saved object modal into new platform"

b8e736a

This reverts commit d0f0ea6. # Conflicts: # src/legacy/core_plugins/kibana/public/discover/np_ready/angular/discover.js

Move save_object_save_modal

b4e2c56

Move show_saved_object_save_modal.tsx

e9ff0e9

Move save_object_finder.tsx

3b365d1

maryia-lapata added Feature:Saved Objects v8.0.0 release_note:skip Skip the PR/issue when compiling release notes Feature:NP Migration v7.7.0 labels Jan 30, 2020

maryia-lapata added 6 commits January 30, 2020 16:50

Remove unused export

053c675

Pass I18nContext to showSaveModal

8d9573b

Merge remote-tracking branch 'kibana/master' into save-object-modal

9e5a5e0

# Conflicts: # src/legacy/core_plugins/kibana/public/dashboard/np_ready/dashboard_app_controller.tsx

Update i18n ids

d0e3f99

Fix map save

255b505

Refactoring

0d6f078

maryia-lapata commented Feb 3, 2020

View reviewed changes

maryia-lapata requested review from flash1293 and streamich February 3, 2020 12:57

maryia-lapata marked this pull request as ready for review February 3, 2020 12:59

maryia-lapata requested a review from a team February 3, 2020 12:59

maryia-lapata requested review from a team as code owners February 3, 2020 12:59

peteharverson approved these changes Feb 3, 2020

View reviewed changes

maryia-lapata added 5 commits February 3, 2020 18:54

Load styles

b2855df

Revert importing styles

e1861a2

Merge remote-tracking branch 'kibana/master' into save-object-modal

6b0bf65

Update snapshot

3507f21

Update snapshot

8c883c0

flash1293 approved these changes Feb 4, 2020

View reviewed changes

maryia-lapata added release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. and removed release_note:skip Skip the PR/issue when compiling release notes labels Feb 4, 2020

Merge branch 'master' into save-object-modal

ec3d6a7

lizozom approved these changes Feb 5, 2020

View reviewed changes

src/plugins/saved_objects/public/saved_object_finder.tsx Show resolved Hide resolved

src/plugins/saved_objects/public/index.ts Outdated Show resolved Hide resolved

maryia-lapata added 2 commits February 5, 2020 15:48

Structural refactoring

91bc118

Fix path

f1faec4

cchaos approved these changes Feb 5, 2020

View reviewed changes

crob611 approved these changes Feb 6, 2020

View reviewed changes

Merge remote-tracking branch 'kibana/master' into save-object-modal

0cf3fc8

# Conflicts: # src/legacy/core_plugins/visualizations/public/np_ready/public/wizard/search_selection/search_selection.tsx

maryia-lapata merged commit f4f5b04 into elastic:master Feb 6, 2020

maryia-lapata deleted the save-object-modal branch February 6, 2020 16:56

maryia-lapata mentioned this pull request Feb 6, 2020

[7.x] [NP] Move saved object modal into new platform (#56383) #57007

Merged

maryia-lapata added the backported label Feb 7, 2020

flash1293 added the Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// label Feb 10, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[NP] Move saved object modal into new platform#56383

[NP] Move saved object modal into new platform#56383
maryia-lapata merged 23 commits intoelastic:masterfrom
maryia-lapata:save-object-modal

maryia-lapata commented Jan 30, 2020 •

edited

Loading

Uh oh!

maryia-lapata Feb 3, 2020

Uh oh!

maryia-lapata Feb 3, 2020

Uh oh!

cchaos Feb 3, 2020

Uh oh!

maryia-lapata Feb 4, 2020

Uh oh!

peteharverson left a comment

Uh oh!

flash1293 left a comment

Uh oh!

maryia-lapata commented Feb 5, 2020

Uh oh!

lizozom left a comment

Uh oh!

Uh oh!

Uh oh!

crob611 left a comment

Uh oh!

kibanamachine commented Feb 6, 2020

Uh oh!

elasticmachine commented Feb 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

maryia-lapata commented Jan 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Dev Docs

Uh oh!

maryia-lapata Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

maryia-lapata Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

cchaos Feb 3, 2020

Choose a reason for hiding this comment

Uh oh!

maryia-lapata Feb 4, 2020

Choose a reason for hiding this comment

Uh oh!

peteharverson left a comment

Choose a reason for hiding this comment

Uh oh!

flash1293 left a comment

Choose a reason for hiding this comment

Uh oh!

maryia-lapata commented Feb 5, 2020

Uh oh!

lizozom left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

crob611 left a comment

Choose a reason for hiding this comment

Uh oh!

kibanamachine commented Feb 6, 2020

💚 Build Succeeded

History

Uh oh!

elasticmachine commented Feb 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

maryia-lapata commented Jan 30, 2020 •

edited

Loading