[APM] Remove service map fullscreen control#56351
Merged
smith merged 1 commit intoelastic:masterfrom Feb 5, 2020
Merged
Conversation
78b42a1 to
d82fb67
Compare
smith
added a commit
to smith/kibana
that referenced
this pull request
Jan 30, 2020
Add center button for service map. The fullscreen button is still there until elastic#56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
smith
added a commit
that referenced
this pull request
Jan 30, 2020
Add center button for service map. The fullscreen button is still there until #56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
smith
added a commit
to smith/kibana
that referenced
this pull request
Jan 31, 2020
Add center button for service map. The fullscreen button is still there until elastic#56351 is merged. Add fit and padding to the layout animation. Make the node labels wider so they aren't cut off.
smith
added a commit
that referenced
this pull request
Jan 31, 2020
dgieselaar
reviewed
Feb 5, 2020
Contributor
dgieselaar
left a comment
There was a problem hiding this comment.
LGTM, just one comment about newlines
Contributor
There was a problem hiding this comment.
should the newline be here? same as below
Contributor
Author
There was a problem hiding this comment.
I think it should. Kibana's .editorconfig has insert_final_newline = true and Prettier puts it there by default. If there's supposed to be an exception here it should be designated by the linter to be so.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
|
merge conflict between base and head |
d82fb67 to
ddfa08b
Compare
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
smith
added a commit
to smith/kibana
that referenced
this pull request
Feb 24, 2020
smith
added a commit
that referenced
this pull request
Feb 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56217