Skip to content

[SIEM] Detections bugs rules#55885

Merged
XavierM merged 4 commits intoelastic:masterfrom
XavierM:detections-bugs-rules
Jan 24, 2020
Merged

[SIEM] Detections bugs rules#55885
XavierM merged 4 commits intoelastic:masterfrom
XavierM:detections-bugs-rules

Conversation

@XavierM
Copy link
Copy Markdown
Contributor

@XavierM XavierM commented Jan 24, 2020

Summary

  • fix re-rendering on timeline table
  • fix UX on all rules page
  • do not query signal outside of your siem signals
  • fix kql on detection page to show signal keys

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@XavierM XavierM added bug Fixes for quality problems that affect the customer experience Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.6.0 labels Jan 24, 2020
@XavierM XavierM self-assigned this Jan 24, 2020
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@XavierM XavierM added the v7.7.0 label Jan 24, 2020
Copy link
Copy Markdown
Member

@spong spong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed client-code and checked out and tested locally and LGTM! Thanks for all the bug and perf fixes @XavierM!

…nts_viewer.tsx

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@XavierM XavierM merged commit 459b8c4 into elastic:master Jan 24, 2020
@XavierM XavierM deleted the detections-bugs-rules branch January 24, 2020 21:42
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 24, 2020
* Fix flow of all rules

* fix the multitude http request + fix table timeline re-rendering

* Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
XavierM added a commit to XavierM/kibana that referenced this pull request Jan 24, 2020
* Fix flow of all rules

* fix the multitude http request + fix table timeline re-rendering

* Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
XavierM added a commit that referenced this pull request Jan 25, 2020
* Fix flow of all rules

* fix the multitude http request + fix table timeline re-rendering

* Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
XavierM added a commit that referenced this pull request Jan 25, 2020
* [SIEM] Detections bugs rules (#55885)

* Fix flow of all rules

* fix the multitude http request + fix table timeline re-rendering

* Update x-pack/legacy/plugins/siem/public/components/events_viewer/events_viewer.tsx

Co-Authored-By: Garrett Spong <spong@users.noreply.github.com>

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>

* fix i18n

Co-authored-by: Garrett Spong <spong@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.6.0 v7.7.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants