Add flag to opt out from sub url tracking#55672
Merged
flash1293 merged 9 commits intoelastic:masterfrom Jan 28, 2020
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
joshdover
reviewed
Jan 23, 2020
Contributor
joshdover
left a comment
There was a problem hiding this comment.
For fixing the core API docs, try doing this:
$ rm -rf target/
$ yarn build:types
And then run the check API / docs script.
| order = 0, | ||
| url, | ||
| subUrlBase, | ||
| disableSubUrlTracking, |
Contributor
There was a problem hiding this comment.
You'll also need to add this to src/legacy/ui/ui_apps/ui_app.js which is also a source of navLinks
Contributor
Author
|
@joshdover That did the trick, thanks 👍 |
Contributor
Author
|
@elasticmachine merge upstream |
pgayvallet
approved these changes
Jan 28, 2020
Contributor
pgayvallet
left a comment
There was a problem hiding this comment.
LGTM for platform changes
…a into exclude-sub-url-tracking
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
flash1293
added a commit
to flash1293/kibana
that referenced
this pull request
Jan 28, 2020
* introduce flag for disabling sub url tracking * re-generate documentation and extend ui_app * fix ui_nav_link test Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 28, 2020
* master: (21 commits) [SIEM][Detection Engine] critical blocker updates to latest ECS version [Monitoring] Fix inaccuracies in logstash pipeline listing metrics (elastic#55868) Resetting errors and removing duplicates (elastic#56054) Add flag to opt out from sub url tracking (elastic#55672) [SIEM][Detection Engine] critical bug, fixes duplicate tags [ML] Anomaly Detection: Fix persist/restore of refreshInterval in globalState. (elastic#56113) [ML] Single Metric Viewer: Fix annnotations refresh. (elastic#56107) adapt ObjectToConfigAdapter.getFlattenedPaths to consider arrays as final values (elastic#56105) Add Appender.receiveAllLevels option to fix LegacyAppender (elastic#55752) [ML] Process delimited files like semi-structured text (elastic#56038) Charts plugin (combining ui/color_maps and EuiUtils) (elastic#55469) fix tutorial documentation (elastic#55996) [ML] Fix persist/restore of time/refreshInterval in data visualizer. (elastic#56122) [Index Management] Fix errors with validation (elastic#56072) [Index Management] Add try/catch when parsing index filter from URI (elastic#56051) [NP] add HTTP resources testing strategies (elastic#54908) [ML] Single Metric Viewer: Fix brush update on short recent timespans. (elastic#56125) [Uptime] Add timeout for slow process to skipped functional tests (elastic#56065) refactor (elastic#56121) Move tests in dashboard into appropriate folders (elastic#55304) ...
flash1293
added a commit
that referenced
this pull request
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds an additional flag to legacy nav links
disableSubUrlTrackingthat mark them to not be included in the auto-sub url tracking of the legacy chrome. This is the first step of incrementally moving this logic into the applications itself.You can test this by adding
disableSubUrlTracking: trueto one of the nav links specified insrc/legacy/core_plugins/kibana/index.jsThe doc builder fails locally for me, that's why the API checker test fails:
node scripts/check_core_api_changes.js --accept