[7.5] [Reporting/Screenshots] Do not fail the report if request is aborted (#52344)#54596
Merged
tsullivan merged 1 commit intoelastic:7.5from Jan 13, 2020
Merged
Conversation
…lastic#52344) * [Reporting/Screenshots] Do not fail the report if request is aborted * take pageRequestFailed out of pageExit observable
tsullivan
commented
Jan 13, 2020
| const failure = req.failure && req.failure(); | ||
| if (failure) { | ||
| this.logger.warning( | ||
| `Request to [${req.url()}] failed! [${failure.errorText}]. This error will be ignored.` |
Member
Author
There was a problem hiding this comment.
This would make page errors (such as the newsfeed service being unavailable) to be logged as a warning instead of cause the reporting job to fail.
Bamieh
approved these changes
Jan 13, 2020
Contributor
Bamieh
left a comment
There was a problem hiding this comment.
code change LGTM. I'll leave approving this change in behavior to someone else that can make this decision.
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
joelgriffith
approved these changes
Jan 13, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #54464
Backports the following commits to 7.5: