Skip to content

Enable functionbeat telemetry#54267

Merged
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:telemetry-beats-fb
Jan 10, 2020
Merged

Enable functionbeat telemetry#54267
ycombinator merged 5 commits intoelastic:masterfrom
ycombinator:telemetry-beats-fb

Conversation

@ycombinator
Copy link
Copy Markdown
Contributor

@ycombinator ycombinator commented Jan 8, 2020 •
edited
Loading

Summary

This PR allows Functionbeat telemetry to be sent through Kibana. The telemetry collection inside Functionbeat was implemented in elastic/beats#14876.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11
- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
- [ ] Documentation was added for features that require explanation or tutorials
- [ ] This was checked for keyboard-only and screenreader accessibility

For maintainers

@ycombinator ycombinator mentioned this pull request Jan 8, 2020
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Jan 9, 2020

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@ycombinator ycombinator requested a review from a team January 10, 2020 13:25
@ycombinator ycombinator added backport pending v7.6.0 v8.0.0 enhancement New value added to drive a business result review labels Jan 10, 2020
@ycombinator ycombinator marked this pull request as ready for review January 10, 2020 13:26
Bamieh
Bamieh approved these changes Jan 10, 2020
View reviewed changes
Copy link
Copy Markdown
Contributor

@Bamieh Bamieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ycombinator ycombinator merged commit 402322c into elastic:master Jan 10, 2020
@ycombinator ycombinator deleted the telemetry-beats-fb branch January 10, 2020 14:17
@ycombinator ycombinator mentioned this pull request Jan 10, 2020
Merged
ycombinator added a commit that referenced this pull request Jan 10, 2020
@ycombinator
Enable functionbeat telemetry (#54267) (#54455)
5d5e5b8 
* Adding placeholder for functionbeat telemetry in test fixture

* Adding placeholder for functionbeat telemetry expectation

* Adding placeholder for aggregating functionbeat telemetry per cluster

* Update test + fixture

* Updating code
@ycombinator ycombinator mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Bamieh Bamieh Bamieh approved these changes

Assignees

No one assigned

Labels

backport pending enhancement New value added to drive a business result release_note:enhancement review v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ycombinator @kibanamachine @Bamieh