[Home][Tutorial] Add STAN data UI#54102
Conversation
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
@kertal since you reviewed the very similar one last time, could you please have a look to this too? :) |
kertal
left a comment
There was a problem hiding this comment.
There seems to be the screenshot file missing. Furthermore, could you prefix the title of this PR with [Home][Tutorial] Then it would be clear which part of Kibana is modified with just a single look Thx a lot 👍
| }, | ||
| }, | ||
| completionTimeMinutes: 10, | ||
| previewImagePath: '/plugins/kibana/home/tutorial_resources/stan_metrics/screenshot.png', |
| @@ -0,0 +1,102 @@ | |||
| <?xml version="1.0" encoding="UTF-8" standalone="no"?> | |||
There was a problem hiding this comment.
Hi, since SVGs aren't automatically minified by Kibana when loaded like this, could you please minify this SVG manually (at least let's remove, the tons of inkscape, sodipodi tags and metadata tags in it), but ideally run it through something like SVGO, please.
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
|
Thank you so much for reviewing folks! @kertal sorry for the missing file, it should be commented out actually since the dashboard is not ready yet. I also changed the tittle of the PR accordingly. @timroes good to know about the svg optimisation, I passed it through https://github.com/svg/svgo, hope it is good now. |
|
@elasticmachine merge upstream |
kertal
left a comment
There was a problem hiding this comment.
Code LGTM, thx for cleaning up and minifying the SVG!
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Signed-off-by: ChrsMark chrismarkou92@gmail.com
Summary
This PR adds data ui for STAN Metricbeat Module.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers