Use savedObjects provided by the platform instead of legacy shim.#53679
Use savedObjects provided by the platform instead of legacy shim.#53679azasypkin merged 1 commit intoelastic:masterfrom
savedObjects provided by the platform instead of legacy shim.#53679Conversation
|
Pinging @elastic/kibana-security (Team:Security) |
There was a problem hiding this comment.
note: made this to be similar to I've done in ESO plugin and also be able to instantiate this logger (and hence initialize Saved Objects wrappers) outside of registerLegacyAPI method.
0ca05ef to
0393fa7
Compare
| legacyAPI: { savedObjects }, | ||
| }: SetupSavedObjectsParams) { | ||
| export function setupSavedObjects({ auditLogger, authz, savedObjects }: SetupSavedObjectsParams) { | ||
| const getKibanaRequest = (request: KibanaRequest | LegacyRequest) => |
There was a problem hiding this comment.
note: according to Rudolf we still need to keep this conversion code here as core doesn't do that for us even though typings for setClientFactory and addClientWrapper say opposite. It should be fixed soon and we can git rid of this function as well.
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
legrego
left a comment
There was a problem hiding this comment.
LGTM! It's always nice when we can delete more code than we add 😄
|
7.x/7.6.0: 78d2362 |
Use
savedObjectsprovided by the platform instead of legacy shim in Security plugin.