[Endpoint] Register endpoint app by kevinlog · Pull Request #53527 · elastic/kibana

kevinlog · 2019-12-18T20:21:28Z

Summary

Register the Endpoint app. This will allow us to expose the UI to users and tests. Also, this allows us to take advantage of spaces and user roles. The Endpoint app is still disabled by default

More information in this github issue: https://github.com/elastic/endpoint-app-team/issues/69

Endpoint app enabled and with a superuser:

User logged in with a role where Endpoint is hidden:

User logged in with a role where Endpoint is visible:

Endpoint app shows up in spaces, can create roles, etc:

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
~~Documentation was added for features that require explanation or tutorials~~
Unit or functional tests were updated or added to match the most common scenarios
~~This was checked for keyboard-only and screenreader accessibility~~

For maintainers

~~This was checked for breaking API changes and was labeled appropriately~~
~~This includes a feature addition or change that requires a release note and was labeled appropriately~~

kevinlog · 2019-12-19T19:18:10Z

@elasticmachine merge upstream

oatkiller · 2019-12-19T20:38:46Z

x-pack/plugins/endpoint/public/plugin.ts

    > {
  public setup(_core: CoreSetup, plugins: EndpointPluginSetupDependencies) {
    const resolverEmbeddableFactory = new ResolverEmbeddableFactory();
+    _core.application.register({


could you rename this to core. The _ prefix is tsserver / tsc speak for 'this is an unused variable'

got it, will do

oatkiller · 2019-12-19T20:43:52Z

x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts

+          basePath: '/s/custom_space',
+        });
+        const navLinks = (await appsMenu.readLinks()).map(
+          (link: Record<string, string>) => link.text


not that it hurts, but you probably shouldn't need to specify the type here. I removed it and the inference seems correct:

Makes sense because appsMenu.readLinks is typed like so:

…to register-endpoint-app

x-pack/plugins/endpoint/public/plugin.ts

legrego

Security changes LGTM with one super-nit

x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts

legrego · 2019-12-20T14:04:11Z

x-pack/plugins/endpoint/server/plugin.ts

+        all: {
+          api: ['resolver'],
+          savedObject: {
+            all: [],


hint I see there's a ui capability here that indicates you may be saving something in the future. When that happens, be sure to update the saved object privileges here with the specific types you need to read and write. We're more than happy to help with this!

legrego · 2019-12-20T14:05:15Z

x-pack/test/functional/apps/endpoint/feature_controls/endpoint_spaces.ts

+import expect from '@kbn/expect';
+import { FtrProviderContext } from '../../../ftr_provider_context';
+
+export default function({ getPageObjects, getService }: FtrProviderContext) {


Thanks for this test suite! 🥇

Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>

elasticmachine · 2019-12-20T15:31:05Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: e1112f3

History

💚 Build #16893 succeeded 26021d8
💔 Build #16818 failed d95a1ea
💚 Build #16798 succeeded 15d4a12
💚 Build #16763 succeeded 476401d
💔 Build #16742 failed d0c45e8

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

* Add Endpoint plugin and Resolver embeddable (#51994) * Add functional tests for plugins to x-pack (so we can do a functional test of the Resolver embeddable) * Add Endpoint plugin * Add Resolver embeddable * Test that Resolver embeddable can be rendered Conflicts: x-pack/.i18nrc.json x-pack/test/api_integration/apis/index.js * [Endpoint] Register endpoint app (#53527) * register app, create functional test * formatting * update tests * adjust test data for endpoint * add endpoint tests for testing spaces, app enabled, disabled, etc * linting * add read privileges to endpoint * rename variable since its used now * remove deprecated context * remove unused variable * fix type check * correct test suite message Co-Authored-By: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> * [Endpoint] add react router to endpoint app (#53808) * add react router to endpoint app * linting * linting * linting * correct tests * change history from hash to browser, add new test util * remove default values in helper functions * fix type check, use FunctionComponent as oppsed to FC * use BrowserRouter component * use BrowserRouter component lin * add comments to test framework, change function name to include browserHistory Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * EMT-issue-65: add endpoint list api (#53861) add endpoint list api * EMT-65:always return accurate endpoint count (#54423) EMT-65:always return accurate endpoint count, independent of paging properties * Resolver component w/ sample data (#53619) Resolver is a map. It shows processes that ran on a computer. The processes are drawn as nodes and lines connect processes with their parents. Resolver is not yet implemented in Kibana. This PR adds a 'map' type UX. The user can click and drag to pan the map and zoom using trackpad pinching (or ctrl and mousewheel.) There is no code providing actual data. Sample data is included. The sample data is used to draw a map. The fundamental info needed is: process names the parent of a process With this info we can topologically lay out the processes. The sample data isn't yet in a realistic format. We'll be fixing that soon. Related issue: elastic/endpoint-app-team#30 * Resolver test plugin not using mount context. (#54933) Mount context was deprecated. Use core.getStartServices() instead. * Resolver nonlinear zoom (#54936) * [Endpoint] add Redux saga Middleware and app Store (#53906) * Added saga library * Initialize endpoint app redux store * Resolver is overflow: hidden to prevent obscured elements from showing up (#55076) * [Endpoint] Fix saga to start only after store is created and stopped on app unmount (#55245) - added `stop()`/`start()` methods to the Saga Middleware creator factory - adjust tests based on changes - changed application `renderApp` to stop sagas when react app is unmounted * Resolver zoom, pan, and center controls (#55221) * Resolver zoom, pan, and center controls * add tests, fix north panning * fix type issue * update west and east panning to behave like google maps * [Endpoint] FIX: Increase tests `sleep` default duration back to 100ms (#55492) Revert `sleep()` default duration, in the saga tests, back to 100ms in order to prevent intermittent failures during CI runs. Fixes #55464 Fixes #55465 * [Endpoint] EMT-65: make endpoint data types common, restructure (#54772) [Endpoint] EMT-65: make endpoint data types common, use schema changes * Basic Functionality Alert List (#55800) * sets up initial grid and data type * data feeds in from backend but doesnt update * sample data feeding in correctly * Fix combineReducers issue by importing Redux type from 'redux' package * Add usePageId hook that fires action when user navigates to page * Strict typing for middleware * addresses comments and uses better types * move types to common/types.ts * Move types to endpoint/types.ts, address PR comments blah 2 Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> * [Endpoint] Add Endpoint Details route (#55746) * Add Endpoint Details route * add Endpoint Details tests * sacrifices to the Type gods * update to latest endpoint schema Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] EMT-67: add kql support for endpoint list (#56328) [Endpoint] EMT-67: add kql support for endpoint list * [Endpoint] ERT-82 ERT-83 ERT-84: Alert list API with pagination (#56538) * ERT-82 ERT-83 ERT-84 (partial): Add Alert List API with pagination * Better type safety for alert list API * Add Test to Verify Endpoint App Landing Page (#57129) Conflicts: x-pack/test/functional/page_objects/index.ts * fixes render bug in alert list (#57152) Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolver: Animate camera, add sidebar (#55590) This PR adds a sidebar navigation. clicking the icons in the nav will focus the camera on the different nodes. There is an animation effect when the camera moves. Conflicts: yarn.lock * [Endpoint] Task/basic endpoint list (#55623) * Adds host management list to endpoint security plugin Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * [Endpoint] Policy List UI route and initial view (#56918) * Initial Policy List view * Add `endpoint/policy` route and displays Policy List * test cases (both unit and functional) Does not yet interact with API (Ingest). * Add ApplicationService app status management (#50223) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * Implements `getStartServices` on server-side (#55156) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. * [ui/utils/query_string]: Remove unused methods & migrate apps to querystring lib (#56957) This was already backported, but changes to endpoint app could not be backported, since endpoint app itself hadn't been backported. Now that the endpoint app is backported, reapply the endpoint specific changes from the original commit. Co-authored-by: Kevin Logan <56395104+kevinlog@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Larry Gregory <lgregorydev@gmail.com> Co-authored-by: nnamdifrankie <56440728+nnamdifrankie@users.noreply.github.com> Co-authored-by: Davis Plumlee <56367316+dplumlee@users.noreply.github.com> Co-authored-by: Paul Tavares <56442535+paul-tavares@users.noreply.github.com> Co-authored-by: Pedro Jaramillo <peluja1012@gmail.com> Co-authored-by: Dan Panzarella <pzl@users.noreply.github.com> Co-authored-by: Madison Caldwell <madison.rey.caldwell@gmail.com> Co-authored-by: Charlie Pichette <56399229+charlie-pichette@users.noreply.github.com> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com> Co-authored-by: Pierre Gayvallet <pierre.gayvallet@gmail.com> Co-authored-by: Alexey Antonov <alexwizp@gmail.com>

kevinlog added 2 commits December 18, 2019 14:31

register app, create functional test

7f58de3

formatting

e1a7bf0

kevinlog added Team:Endpoint Data Visibility Team managing the endpoint resolver Team:Endpoint Management Team:Endpoint Response Endpoint Response Team v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Dec 18, 2019

update tests

62b6c56

kevinlog requested a review from a team as a code owner December 18, 2019 22:31

kevinlog added 4 commits December 19, 2019 11:34

adjust test data for endpoint

e7aed9e

add endpoint tests for testing spaces, app enabled, disabled, etc

bdbe686

linting

d0c45e8

add read privileges to endpoint

6914221

Merge branch 'master' into register-endpoint-app

476401d

oatkiller approved these changes Dec 19, 2019

View reviewed changes

kevinlog changed the title ~~[WIP][Endpoint] Register endpoint app~~ [Endpoint] Register endpoint app Dec 19, 2019

kevinlog requested a review from joshdover December 19, 2019 21:26

kevinlog added 2 commits December 19, 2019 16:44

rename variable since its used now

8b5f89f

Merge branch 'register-endpoint-app' of github.com:kevinlog/kibana in…

15d4a12

…to register-endpoint-app

rudolf approved these changes Dec 19, 2019

View reviewed changes

joshdover reviewed Dec 19, 2019

View reviewed changes

x-pack/plugins/endpoint/public/plugin.ts Outdated Show resolved Hide resolved

kevinlog added 2 commits December 19, 2019 17:40

remove deprecated context

1c9e1ad

remove unused variable

d95a1ea

joshdover approved these changes Dec 19, 2019

View reviewed changes

fix type check

26021d8

azasypkin self-requested a review December 20, 2019 14:05

legrego approved these changes Dec 20, 2019

View reviewed changes

azasypkin removed their request for review December 20, 2019 14:09

correct test suite message

e1112f3

Co-Authored-By: Larry Gregory <lgregorydev@gmail.com>

kevinlog merged commit 2f3ca65 into elastic:master Dec 20, 2019

kevinlog deleted the register-endpoint-app branch December 20, 2019 15:31

kevinlog added the Feature:Endpoint Elastic Endpoint feature label Jan 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Endpoint] Register endpoint app#53527

[Endpoint] Register endpoint app#53527
kevinlog merged 14 commits intoelastic:masterfrom
kevinlog:register-endpoint-app

kevinlog commented Dec 18, 2019 •

edited

Loading

Uh oh!

kevinlog commented Dec 19, 2019

Uh oh!

oatkiller Dec 19, 2019

Uh oh!

kevinlog Dec 19, 2019

Uh oh!

oatkiller Dec 19, 2019

Uh oh!

Uh oh!

legrego left a comment

Uh oh!

Uh oh!

legrego Dec 20, 2019

Uh oh!

legrego Dec 20, 2019

Uh oh!

elasticmachine commented Dec 20, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

kevinlog commented Dec 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

kevinlog commented Dec 19, 2019

Uh oh!

oatkiller Dec 19, 2019

Choose a reason for hiding this comment

Uh oh!

kevinlog Dec 19, 2019

Choose a reason for hiding this comment

Uh oh!

oatkiller Dec 19, 2019

Choose a reason for hiding this comment

Uh oh!

Uh oh!

legrego left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

legrego Dec 20, 2019

Choose a reason for hiding this comment

Uh oh!

legrego Dec 20, 2019

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Dec 20, 2019

💚 Build Succeeded

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

kevinlog commented Dec 18, 2019 •

edited

Loading