NP Migration: Rollup plugin#53503
Conversation
This comment has been minimized.
This comment has been minimized.
5bf8e03 to
b6f1f9e
Compare
|
With regards to the issue: I am still able to reproduce it. I learned that this happens when specifying an index pattern like The UI is specifically breaking because
So it does look like a regression introduced here. Let me know if you need more info! |
| id: 'rollup', | ||
|
|
||
| search: ({ searchRequests, Promise }) => { |
There was a problem hiding this comment.
I removed Promise because it isn't passed here any more
https://github.com/elastic/kibana/blob/master/src/plugins/data/public/search/search_strategy/types.ts#L35
jloleysens
left a comment
There was a problem hiding this comment.
Tested locally and am happy with the proposed changes overall. Left some non-blocker comments.
|
@jloleysens finally I reproduced the issue. Thanks for explanation. It was caused by a mistake in the code (here). How it looks now: On the screenshot a status code is displayed as well. It was already envisaged here. |
# Conflicts: # x-pack/legacy/plugins/rollup/public/visualize/editor_config.js
lizozom
left a comment
There was a problem hiding this comment.
Didn't pull down to test.
@elastic/kibana-app-arch changes are 1 file
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
* Start shimming rollup plugin * continued shimming rollup ui * Remove unnecessarily return * Register management section * Replace ui/chrome * Replace ui/documentation_links * Replace ui/kfetch and ui/courier * Start shimming rollup plugin * continued shimming rollup ui * Remove unnecessarily return * Register management section * Replace ui/chrome * Replace ui/documentation_links * Replace ui/kfetch and ui/courier * Replace ui/notify * Move ui/ imports to legacy_imports.ts * Update NP mock for management * Refactoring * Read body from error object * Update setup_environment.js * Update unit tests * Get rid of injectI18n * Replace npStart and npSetup usage to services * Import search strategy stuff from the top level of the data plugin * Update unit tests * Do not prepend the url * Fix merge conflicts * Refactoring * Revert removal of setUserHasLeftApp * Export getSearchErrorType * Remove extra wrapper - Router * Fix cause prop. * Leave just static imports in legacy_imports.js * Add TS * Pass statusCode instead of statusText * Move template in a separate file * Move app register to setup * Add karma mock for management setup * Add EditorConfigProviderRegistry export Co-authored-by: Maryia Lapata <mary.lopato@gmail.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Joe Reuter <email@johannes-reuter.de> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
This PR includes shimming of the Rollup plugin.
Early stages WIP PR:
[ ] convert to typescript(moved to the Phase III)Also here I got rid of
injectI18n.