Security/Spaces - cleanup react warnings#53287
Merged
legrego merged 2 commits intoelastic:masterfrom Dec 19, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-security (Team:Security) |
Member
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
Contributor
|
ACK: will review today or tomorrow CET morning. |
azasypkin
approved these changes
Dec 19, 2019
| await Promise.resolve(); | ||
|
|
||
| wrapper.update(); | ||
| await act(async () => { |
Member
Author
There was a problem hiding this comment.
I came across that utility when writing tests for the role management UI. I thought you'd appreciate that change!
legrego
added a commit
that referenced
this pull request
Dec 19, 2019
mbondyra
added a commit
to mbondyra/kibana
that referenced
this pull request
Dec 19, 2019
…f github.com:mbondyra/kibana into IS-51910_share-lens-change-index-pattern-in-discover * 'IS-51910_share-lens-change-index-pattern-in-discover' of github.com:mbondyra/kibana: [Discover] Remove angular field filter template code (elastic#53513) [APM] Improve table and other panel loading states (elastic#53459) Security/Spaces - cleanup react warnings (elastic#53287) Revert "NP licensing add functional tests (elastic#53002)" (elastic#53577) NP licensing add functional tests (elastic#53002) fix onLicenseInfoChange callback to be called on update (elastic#53559) Document how to extend request handler context (elastic#53271)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses React warnings in the Spaces and Security plugins. Most changes were test related, with a couple of changes from
componentWillMounttocomponentDidMount.There is one outstanding warning thrown when running our test suite, but it is thrown by
FormattedRelative, which is part of our@kbn/i18npackage as a result of an older version ofreact-intl. This should be resolved once #38642 is addressed.