Fix ClusterManager call parameters#53263
Merged
pgayvallet merged 4 commits intoelastic:masterfrom Dec 18, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-platform (Team:Platform) |
pgayvallet
commented
Dec 17, 2019
Comment on lines
-256
to
+258
| require('../../../cli/cluster/cluster_manager').create( | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const ClusterManager = require('../../../cli/cluster/cluster_manager'); | ||
| return new ClusterManager( |
Contributor
Author
There was a problem hiding this comment.
Using the public constructor instead of the static create, as we already have the legacy-plugin-mutated config and want to use this one.
Contributor
There was a problem hiding this comment.
Does that mean we can remove the static factory function create or is it still being used somewhere?
Contributor
Author
There was a problem hiding this comment.
We might be able to do that. will grep and see
Contributor
Author
|
retest |
rudolf
approved these changes
Dec 17, 2019
Comment on lines
-256
to
+258
| require('../../../cli/cluster/cluster_manager').create( | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires | ||
| const ClusterManager = require('../../../cli/cluster/cluster_manager'); | ||
| return new ClusterManager( |
Contributor
There was a problem hiding this comment.
Does that mean we can remove the static factory function create or is it still being used somewhere?
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
pgayvallet
added a commit
to pgayvallet/kibana
that referenced
this pull request
Dec 18, 2019
* Fix ClusterManager call parameters * remove static ClusterManager.create * migrate ClusterManager to ts * remove default import for ClusterManager and Worker
pgayvallet
added a commit
that referenced
this pull request
Dec 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix #52860
Checklist