Merged
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
added 12 commits
December 10, 2019 14:30
lukeelmers
reviewed
Dec 12, 2019
…plugin/move-search-bar
lukeelmers
approved these changes
Dec 13, 2019
Contributor
lukeelmers
left a comment
There was a problem hiding this comment.
Code LGTM, once everything is green!
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
pushed a commit
to lizozom/kibana
that referenced
this pull request
Dec 13, 2019
* Moved SearchBar component to NP * move search bar to NP * change import * Revert "change import" This reverts commit 52d990f. * Revert "move search bar to NP" This reverts commit 4196e8b. * move create search bar * Clean up jest mocks * update snapshots * Remove indexPatterns angular service * Deleted comment * Mock npStart.core.savedObjects * Removed export of SearchBarOwnProps * fix import * Fix typo * eslint
lizozom
pushed a commit
that referenced
this pull request
Dec 13, 2019
* Moved SearchBar component to NP * move search bar to NP * change import * Revert "change import" This reverts commit 52d990f. * Revert "move search bar to NP" This reverts commit 4196e8b. * move create search bar * Clean up jest mocks * update snapshots * Remove indexPatterns angular service * Deleted comment * Mock npStart.core.savedObjects * Removed export of SearchBarOwnProps * fix import * Fix typo * eslint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Solves #51028
Move search bar to NP
Remove left usages of
indexPatternsangular service (as it was causing errors loading timelion app).Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers