[ML] Functional tests - export service types#52612
Merged
pheyos merged 1 commit intoelastic:masterfrom Dec 11, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build SucceededTo update your PR or re-run it, just comment with: |
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Dec 12, 2019
With this PR the types of the ML services that are used in other services are exported from the service file to allow a cleaner re-use.
pheyos
added a commit
to pheyos/kibana
that referenced
this pull request
Dec 12, 2019
With this PR the types of the ML services that are used in other services are exported from the service file to allow a cleaner re-use.
pheyos
added a commit
that referenced
this pull request
Dec 12, 2019
pheyos
added a commit
that referenced
this pull request
Dec 12, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
With this PR the types of the ML services that are used in other services are exported from the service file to allow a cleaner re-use.
This is following @spalger 's suggestion in #52167 (comment)