[ui/public/utils] Delete unused base_object & find_by_param#52500
Merged
alexwizp merged 2 commits intoelastic:masterfrom Dec 11, 2019
Merged
[ui/public/utils] Delete unused base_object & find_by_param#52500alexwizp merged 2 commits intoelastic:masterfrom
alexwizp merged 2 commits intoelastic:masterfrom
Conversation
1b1b50a to
76242a1
Compare
76242a1 to
4d02949
Compare
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
lizozom
reviewed
Dec 9, 2019
| * | ||
| * @return {object} | ||
| */ | ||
| State.prototype.toObject = function () { |
Contributor
There was a problem hiding this comment.
Is this related to the deletions?
If not, what is this related to?
Contributor
Author
There was a problem hiding this comment.
Please see removed src/legacy/ui/public/utils/base_object.ts file
Contributor
Author
There was a problem hiding this comment.
@lizozom sorry for not detailed answer. Please see next diagram
Contributor
There was a problem hiding this comment.
That was a great explanation
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
lizozom
approved these changes
Dec 10, 2019
Contributor
lizozom
left a comment
There was a problem hiding this comment.
Tested dashboard \ visualization state changes.
LGTM.
This was referenced Dec 10, 2019
alexwizp
added a commit
to alexwizp/kibana
that referenced
this pull request
Dec 11, 2019
alexwizp
added a commit
that referenced
this pull request
Dec 11, 2019
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Dec 11, 2019
…le-sql-highlighting * 'master' of github.com:elastic/kibana: (56 commits) Migrate url shortener service (elastic#50896) Re-enable datemath in from/to canvas timelion args (elastic#52159) [Logs + Metrics UI] Remove eslint exceptions (elastic#50979) [Logs + Metrics UI] Add missing headers in Logs & metrics (elastic#52405) [ML] API integration tests - initial tests for bucket span estimator (elastic#52636) [Watcher] New Platform (NP) Migration (elastic#50908) Decouple Authorization subsystem from Legacy API. (elastic#52638) [APM] Fix some warnings logged in APM tests (elastic#52487) [ui/public/utils] Delete unused base_object & find_by_param (elastic#52500) [ui/public/utils] Move items into ui/vis (elastic#52615) fix newlines in kbn-analytics build script Add top level examples folder and command to run, `--run-examples`. (elastic#52027) feat(NA): add trap for SIGINT in the git precommit hook (elastic#52662) [DOCS] Updtes description of elasticsearch.requestHeadersWhitelist (elastic#52675) [Telemetry/Pulse] Updates advanced settings text for usage data (elastic#52657) [SIEM][Detection Engine] Adds the default name space to the end of the signals index [Logs UI] Generalize ML module management (elastic#50662) Removing stateful saved object finder (elastic#52166) Shim oss telemetry (elastic#51168) [Reporting/Screenshots] Do not fail the report if request is aborted (elastic#52344) ... # Conflicts: # src/legacy/core_plugins/console/public/legacy.ts # src/legacy/core_plugins/console/public/np_ready/application/models/legacy_core_editor/mode/elasticsearch_sql_highlight_rules.ts # src/legacy/core_plugins/console/public/np_ready/lib/autocomplete/components/full_request_component.ts # src/legacy/core_plugins/console/public/quarantined/src/sense_editor/row_parser.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #51854
Summary
There are a few utils in src/legacy/ui/public/utils that appear to be unused in Kibana:
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers