[Canvas] Refactor Canvas to no longer use componentWillReceiveProps#52129
Merged
poffdeluxe merged 8 commits intoelastic:masterfrom Dec 30, 2019
Merged
[Canvas] Refactor Canvas to no longer use componentWillReceiveProps#52129poffdeluxe merged 8 commits intoelastic:masterfrom
poffdeluxe merged 8 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
This reverts commit 255525d.
Contributor
Author
|
@elasticmachine merge upstream |
crob611
approved these changes
Dec 20, 2019
Contributor
crob611
left a comment
There was a problem hiding this comment.
Changes look good. Tested all of the scenarios I could think of involving these and didn't see anything out of the ordinary. 👍
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build SucceededHistory
To update your PR or re-run it, just comment with: |
poffdeluxe
added a commit
to poffdeluxe/kibana
that referenced
this pull request
Dec 30, 2019
…lastic#52129) * Removing componentWillReceiveProps from time filter * Changing expression form to componentDidUpdate * Updating expression to be key-driven updates and arg_types to use compomentDidUpdate * temporary * Revert "temporary" This reverts commit 255525d. * typo fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
poffdeluxe
added a commit
that referenced
this pull request
Dec 30, 2019
…52129) (#53843) * Removing componentWillReceiveProps from time filter * Changing expression form to componentDidUpdate * Updating expression to be key-driven updates and arg_types to use compomentDidUpdate * temporary * Revert "temporary" This reverts commit 255525d. * typo fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 2, 2020
* master: Bump year in NOTICE.txt Add kibanamachine support to Github PR comments (elastic#53852) Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333) Skip failing test suite [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799) Do not remount applications between page navigations (elastic#53851) [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129) [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 2, 2020
* master: Bump year in NOTICE.txt Add kibanamachine support to Github PR comments (elastic#53852) Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333) Skip failing test suite [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799) Do not remount applications between page navigations (elastic#53851) [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129) [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 2, 2020
* master: Bump year in NOTICE.txt Add kibanamachine support to Github PR comments (elastic#53852) Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333) Skip failing test suite [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799) Do not remount applications between page navigations (elastic#53851) [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129) [Canvas] Migrate usage collector to NP plugin (elastic#53303)
gmmorris
added a commit
to gmmorris/kibana
that referenced
this pull request
Jan 2, 2020
* master: Fix suggested value for time_zone in range query (elastic#53841) Clean up generic hooks, use react-use instead (elastic#53822) Bump year in NOTICE.txt Add kibanamachine support to Github PR comments (elastic#53852) Add tests to ensure AAD isn't broken after performing a change on an alert / action (elastic#53333) Skip failing test suite [Vega] Sample [Flights] Airport Connections (Hover Over Airport) visualization not working (elastic#53799) Do not remount applications between page navigations (elastic#53851) [Canvas] Refactor Canvas to no longer use componentWillReceiveProps (elastic#52129) [Canvas] Migrate usage collector to NP plugin (elastic#53303)
jkelastic
pushed a commit
to jkelastic/kibana
that referenced
this pull request
Jan 8, 2020
…lastic#52129) * Removing componentWillReceiveProps from time filter * Changing expression form to componentDidUpdate * Updating expression to be key-driven updates and arg_types to use compomentDidUpdate * temporary * Revert "temporary" This reverts commit 255525d. * typo fix Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing
componentWillReceivePropsand replacing it withcomponentDidUpdatein most places.For the
Expressioncomponent, we're using a React key to force the component to reset state (as recommended by the React folks here: https://reactjs.org/blog/2018/06/07/you-probably-dont-need-derived-state.html#recommendation-fully-uncontrolled-component-with-a-key)Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials~~- [ ] Unit or functional tests were updated or added to match the most common scenarios
- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers