Skip to content

[Tests] Add a helper to detect if functional tests are running against cloud#51817

Merged
chrisronline merged 10 commits intoelastic:masterfrom
chrisronline:functional_tests/is_cloud
Dec 16, 2019
Merged

[Tests] Add a helper to detect if functional tests are running against cloud#51817
chrisronline merged 10 commits intoelastic:masterfrom
chrisronline:functional_tests/is_cloud

Conversation

@chrisronline
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline commented Nov 27, 2019

This PR adds a helper method to the common page object that will detect if the functional tests are running against cloud or not.

This should help manage tests that fail only on cloud, as we can now fork the test based on the the response from this helper and still ensure cloud coverage.

This relates to #51477 where the UI is slightly different for cloud (as they do not support monitoring with metricbeat) but a simple fork in the test will allow the test to work for cloud too.

cc @tsullivan @stacey-gammon per our slack conversation

@chrisronline chrisronline self-assigned this Nov 27, 2019
@chrisronline chrisronline added the release_note:skip Skip the PR/issue when compiling release notes label Nov 27, 2019
This was referenced Nov 27, 2019
Closed
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 27, 2019

💔 Build Failed

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 2, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2019

💚 Build Succeeded

@tsullivan tsullivan self-requested a review December 2, 2019 18:21
tsullivan
tsullivan reviewed Dec 2, 2019
View reviewed changes
tsullivan
tsullivan requested changes Dec 2, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good and I agree with the method, because this condition is needed.

As much as I like atomically small PRs, I think this PR should come with the isCloud method being used in a test somewhere. Because there's no guarantee this test method really works.

Also, had a minor question about TS inference.

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 2, 2019

@tsullivan I added a test change, which will account for #51477. The testing of this is a little cumbersome, in that you'll need to run tests against 7.5 cloud (which is in staging) on a 7.5 version of Kibana. I don't know of a place/way to test against cloud running master so this is how I've been handling it.

My test looks like:

TEST_ES_URL=https://elastic:<password>@<cloud_es_instance> TEST_KIBANA_URL=https://elastic:h<password>@<cloud_kibana_instance> node ../scripts/functional_test_runner --grep "Monitoring is turned off" --bail

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2019

💚 Build Succeeded

@chrisronline chrisronline mentioned this pull request Dec 9, 2019
Closed
tsullivan
tsullivan approved these changes Dec 11, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@tsullivan tsullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 11, 2019

@elasticmachine merge upstream

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 13, 2019

@elasticmachine merge upstream

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 13, 2019

@elasticmachine merge upstream

@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 16, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 16, 2019

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@chrisronline chrisronline merged commit 5ec3b03 into elastic:master Dec 16, 2019
@chrisronline chrisronline deleted the functional_tests/is_cloud branch December 16, 2019 18:18
@chrisronline chrisronline mentioned this pull request Dec 16, 2019
Merged
chrisronline added a commit to chrisronline/kibana that referenced this pull request Dec 16, 2019
@chrisronline
[Tests] Add a helper to detect if functional tests are running agains…
fb6398c 
…t cloud (elastic#51817)

* Add a helper to detect if functional tests are running against cloud

* PR feedback

* Clean up comment

* New eslint rules applied
chrisronline added a commit that referenced this pull request Dec 16, 2019
@chrisronline
[Tests] Add a helper to detect if functional tests are running agains…
41787f8 
…t cloud (#51817) (#53164)

* Add a helper to detect if functional tests are running against cloud

* PR feedback

* Clean up comment

* New eslint rules applied
@chrisronline
Copy link
Copy Markdown
Contributor Author

chrisronline commented Dec 17, 2019

Backport:

7.x: 41787f8

@chrisronline chrisronline mentioned this pull request Jun 15, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tsullivan tsullivan tsullivan approved these changes

Assignees

@chrisronline chrisronline

Labels

release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@chrisronline @elasticmachine @tsullivan