[Maps] [Telemetry] Count indices with geo-fields#51221
Merged
thomasneirynck merged 5 commits intoelastic:masterfrom Nov 21, 2019
Merged
[Maps] [Telemetry] Count indices with geo-fields#51221thomasneirynck merged 5 commits intoelastic:masterfrom
thomasneirynck merged 5 commits intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-gis (Team:Geo) |
nreese
reviewed
Nov 20, 2019
x-pack/legacy/plugins/maps/server/maps_telemetry/maps_telemetry.test.js
Outdated
Show resolved
Hide resolved
...cy/plugins/maps/server/maps_telemetry/test_resources/sample_index_pattern_saved_objects.json
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
kindsun
reviewed
Nov 20, 2019
nreese
reviewed
Nov 21, 2019
| } | ||
|
|
||
| async function getIndexPatternSavedObjects(savedObjectsClient) { | ||
| const indexPatternSavedObjects = await savedObjectsClient.find({ type: 'index-pattern' }); |
Contributor
There was a problem hiding this comment.
You need to set per_page and page through results. Otherwise, you are only going to gets stats on first 20 index-patterns. https://github.com/elastic/kibana/blob/master/src/core/server/saved_objects/service/lib/repository.ts#L417
The same is true when fetching map saved objects.
Contributor
Author
There was a problem hiding this comment.
Aha, didn't know that, thanks!
Let's address in separate PR #51345
Contributor
💚 Build Succeeded |
kindsun
approved these changes
Nov 21, 2019
Contributor
kindsun
left a comment
There was a problem hiding this comment.
nice addition. lgtm!
- code review
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 21, 2019
thomasneirynck
added a commit
that referenced
this pull request
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #48790