Skip to content

Move @kbn/es-query into data plugin - kuery folder#51014

Merged
lukeelmers merged 18 commits intoelastic:masterfrom
alexwizp:es-query_kuery
Nov 26, 2019
Merged

Move @kbn/es-query into data plugin - kuery folder#51014
lukeelmers merged 18 commits intoelastic:masterfrom
alexwizp:es-query_kuery

Conversation

@alexwizp
Copy link
Copy Markdown
Contributor

@alexwizp alexwizp commented Nov 19, 2019

Summary

Part of #42885

What should be done in this PR:

  • Remove @kbn/es-query module and exclude it from the build process
  • Replace all import links from @kbn/es-query -> 'src/plugins/data/{server|public}
  • Migrate tests from Mocha -> Jest
  • Migrate all files from ./es-query/kuery to typescript. Will be done in a separate PR

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@alexwizp alexwizp added the WIP Work in progress label Nov 19, 2019
@alexwizp alexwizp changed the title Move @kbn/es-query into data plugin - kuery folder [WIP] Move @kbn/es-query into data plugin - kuery folder Nov 19, 2019
@alexwizp alexwizp self-assigned this Nov 19, 2019
@alexwizp alexwizp added v7.6.0 v8.0.0 release_note:skip Skip the PR/issue when compiling release notes labels Nov 19, 2019
@elastic elastic deleted a comment from elasticmachine Nov 19, 2019
@alexwizp

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elastic elastic deleted a comment from elasticmachine Nov 20, 2019
@elastic elastic deleted a comment from elasticmachine Nov 20, 2019
@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@alexwizp
Copy link
Copy Markdown
Contributor Author

alexwizp commented Nov 20, 2019

@lukeelmers @Bargs what do you think about merging these changes and finishing the following items in a separate PR:

  • Migrate all files from ./es-query/kuery to typescript
  • Migrate tests from Mocha -> Jest

@alexwizp
Copy link
Copy Markdown
Contributor Author

Migrate tests from Mocha -> Jest item was done

@alexwizp alexwizp added Feature:Query Bar Querying and query bar features Feature:Search Querying infrastructure in Kibana Team:AppArch labels Nov 21, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@elasticmachine

This comment has been minimized.

@lukeelmers
Copy link
Copy Markdown
Contributor

After discussion with @Bargs @joshdover and @rudolf, we've confirmed that we will go ahead and merge this once it passes CI. The follow-up task (Option 3 in Rudolf's list above) will be tracked in #51659.

@elasticmachine

This comment has been minimized.

@lukeelmers
Copy link
Copy Markdown
Contributor

@elasticmachine merge upstream

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@alexwizp
Copy link
Copy Markdown
Contributor Author

@lukeelmers thank you 🙇‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:NP Migration Feature:Query Bar Querying and query bar features Feature:Search Querying infrastructure in Kibana release_note:skip Skip the PR/issue when compiling release notes review v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.