Move @kbn/es-query into data plugin - kuery folder#51014
Merged
lukeelmers merged 18 commits intoelastic:masterfrom Nov 26, 2019
Merged
Move @kbn/es-query into data plugin - kuery folder#51014lukeelmers merged 18 commits intoelastic:masterfrom
lukeelmers merged 18 commits intoelastic:masterfrom
Conversation
10 tasks
ad49105 to
c82d463
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1886d95 to
0165c46
Compare
Contributor
💚 Build Succeeded
|
Contributor
Author
|
@lukeelmers @Bargs what do you think about merging these changes and finishing the following items in a separate PR:
|
Contributor
Author
|
|
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
3dc2886 to
f993bd2
Compare
This comment has been minimized.
This comment has been minimized.
3 tasks
Contributor
|
After discussion with @Bargs @joshdover and @rudolf, we've confirmed that we will go ahead and merge this once it passes CI. The follow-up task (Option 3 in Rudolf's list above) will be tracked in #51659. |
This comment has been minimized.
This comment has been minimized.
Contributor
|
@elasticmachine merge upstream |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
Author
|
@lukeelmers thank you 🙇♂️ |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Part of #42885
What should be done in this PR:
@kbn/es-query -> 'src/plugins/data/{server|public}Migrate all files from ./es-query/kuery to typescript.Will be done in a separate PRChecklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers