Move local application service into Kibana platform#50661
Move local application service into Kibana platform#50661kertal merged 20 commits intoelastic:masterfrom
Conversation
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
💚 Build Succeeded |
| instance.start(npStart.core, { | ||
| newPlatformDevTools: npStart.plugins.devTools, | ||
| }); | ||
| if (npStart.plugins.devTools.getSortedDevTools().length === 0) { |
There was a problem hiding this comment.
@restrry qq: What's the convention for plugin naming? There is feature_catalogue, but uiActions
There was a problem hiding this comment.
all legacy plugins use snake_case for naming https://github.com/elastic/kibana/tree/master/src/legacy/core_plugins
There was a problem hiding this comment.
@streamich do you want me to create an issue to fix that for ui_actions?
There was a problem hiding this comment.
@restrry Ah, maybe I wasn't clear. I was talking about the id of the plugin. The ui_actions/uiActions plugin uses snake case for the directory, but camel case for the id.
There was a problem hiding this comment.
@flash1293 I got it. I didn't find name in camelCase within https://github.com/elastic/kibana/tree/master/src/legacy/core_plugins
In LP name === id https://github.com/restrry/kibana/blob/41b49358e6626809d0ed479c53aa711bb430bbbe/src/legacy/plugin_discovery/plugin_spec/plugin_spec.js#L32
💚 Build Succeeded |
💚 Build Succeeded |
💚 Build Succeeded |
💔 Build Failed |
💔 Build Failed |
|
Jenkins, test this. |
💚 Build Succeeded |
wylieconlon
left a comment
There was a problem hiding this comment.
I get a warning when I open the help menu in Lens:
React Intl] Could not find required intl object. <IntlProvider> needs to exist in the component ancestry. Using default message as fallback.
wylieconlon
left a comment
There was a problem hiding this comment.
The Lens code changes LGTM, but I did find an I18n warning with them.
kertal
left a comment
There was a problem hiding this comment.
Code LGTM ,tested locally with Chrome
💚 Build Succeeded |
…na into kibana-app-registry-in-np
💚 Build Succeeded |
|
@wylieconlon since the warning is gone, you're good from lens side, merging this ? thx |
wylieconlon
left a comment
There was a problem hiding this comment.
Lens changes LGTM, did not re-test locally
* move local application service registry to new platform * move dev tools app itself * fix i18n * make sure legacy dev tools are imported * rename dev tools plugin
This PR moves the registry part of the local application service of the Kibana app plugin into the Kibana platform. By doing this apps registering into the local application service can already move to the new platform even when they have to be rendered without reload when switching from dashboard or visualize.
The dev tools app is already legacy-dependency free and is also moved over in this PR except for the