[SIEM] Add hosts and network anomalies histogram#50295
[SIEM] Add hosts and network anomalies histogram#50295patrykkopycinski merged 20 commits intoelastic:masterfrom
Conversation
|
Pinging @elastic/siem (Team:SIEM) |
💔 Build Failed |
💔 Build Failed |
💔 Build Failed |
| filterQuery?: string | ESTermQuery; | ||
| } | ||
|
|
||
| export type AnomaliesTableComponent = Omit<AnomaliesNetworkTableProps, 'type'> & { |
There was a problem hiding this comment.
The name of this type does actually sounds like a component here, and at the same time we do also use the same name as a props/component, therefore I'd recommend to rename this type.
|
Hey Patryk, I had a quick look over it, it's nice to see it's been added on both hosts and network page. Good stuff!! Thanks a lot. I'll keep reading and playing around with it. Since I'm also working on similar stuff, here are some questions I have that I'd like to confirm with @cwurm, may be worth considering here as well:
|
|
I also would like to check with you if it does make sense to have a histogram on IP details page? @cwurm @tsg @stephmilovic |
|
From the user perspective, based on the screenshot, this looks good to me. Timestamp on the x-axis and job name as legend seems like what we need.
I'd say it logically makes sense. The only consideration is that we don't have tabs there and we have to be ready that most often this chart will be empty. I wonder if it would make sense to hide it when empty? |
|
@elasticmachine merge upstream |
💔 Build Failed |
…s-anomalies-histogram
…kkopycinski/kibana into feat/add-hosts-anomalies-histogram
💔 Build Failed |
💔 Build Failed |
…s-anomalies-histogram # Conflicts: # x-pack/legacy/plugins/siem/public/pages/network/ip_details/index.tsx
💔 Build Failed |
…s-anomalies-histogram
💚 Build Succeeded |
x-pack/legacy/plugins/siem/public/containers/anomalies/anomalies_query_tab_body/index.tsx
Show resolved
Hide resolved
angorayc
left a comment
There was a problem hiding this comment.
Thank you Patryk, nice and clean code as always!! Please feel free to merge after resolving the conflict.
…s-anomalies-histogram # Conflicts: # x-pack/legacy/plugins/siem/server/lib/compose/kibana.ts
💔 Build Failed |
💔 Build Failed |
|
Hey Patryk, sorry the type check failed, I've tried another way to fix it and passed the type check locally, please let me know what you think |
|
After playing around with it, I think I'm fine with the original solution as otherwise it take more actions to fix that and not sure if it worth the time. |
66db385 to
752fd6f
Compare
💔 Build Failed |
…s-anomalies-histogram
💔 Build Failed |
…s-anomalies-histogram # Conflicts: # x-pack/legacy/plugins/siem/public/pages/network/navigation/dns_query_tab_body.tsx # x-pack/legacy/plugins/siem/public/pages/network/navigation/network_routes.tsx
💔 Build Failed |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
Summary
Implements #42461
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately