Skip to content

Add getStartServices API#50231

Merged
joshdover merged 3 commits intoelastic:masterfrom
joshdover:np/bind-services
Dec 12, 2019
Merged

Add getStartServices API#50231
joshdover merged 3 commits intoelastic:masterfrom
joshdover:np/bind-services

Conversation

@joshdover
Copy link
Copy Markdown
Contributor

@joshdover joshdover commented Nov 11, 2019 •
edited
Loading

Summary

Fixes #49691

This adds a new API to the client-side CoreSetup type for accessing start contracts. This is intended to eventually replace the context pattern which will be removed in the future.

The name of this API method is up for discussion: #49691 (comment)

Dev Docs

Context is being deprecated on the front-end and replaced by the core.getStartServices() API.

class Plugin {
  setup(core, plugins) {
    core.application.register({
      id: 'myApp',
      title: 'My App',
      // `mount` functions with just one argument will only receive `params`
      async mount(params) {
        const [coreStart, depsStart] = await core.getStartServices();
        const { renderApp } = await import('./application');
        return renderApp(coreStart, depsStart, params);
      }
    });
  }
}

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

For maintainers

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 11, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 23, 2019

💔 Build Failed

@joshdover joshdover mentioned this pull request Nov 25, 2019
Merged
2 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 25, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 26, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 27, 2019

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 2, 2019

💚 Build Succeeded

@joshdover joshdover force-pushed the np/bind-services branch 2 times, most recently from f77672c to a63355a Compare December 4, 2019 22:47
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2019

💚 Build Succeeded

@joshdover joshdover added Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.6.0 labels Dec 5, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2019

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover marked this pull request as ready for review December 5, 2019 15:19
@joshdover joshdover requested a review from a team as a code owner December 5, 2019 15:19
@joshdover joshdover mentioned this pull request Dec 5, 2019
Merged
8 tasks
@pgayvallet pgayvallet mentioned this pull request Dec 7, 2019
Closed
pgayvallet
pgayvallet reviewed Dec 7, 2019
View reviewed changes
@joshdover joshdover requested a review from pgayvallet December 9, 2019 18:00
@joshdover joshdover force-pushed the np/bind-services branch 2 times, most recently from 7594850 to cabb09f Compare December 9, 2019 22:49
pgayvallet
pgayvallet approved these changes Dec 10, 2019
View reviewed changes
@joshdover joshdover merged commit 2d36989 into elastic:master Dec 12, 2019
@joshdover joshdover deleted the np/bind-services branch December 12, 2019 19:21
This was referenced Dec 12, 2019
Merged
Closed
@jgowdyelastic jgowdyelastic mentioned this pull request Dec 12, 2019
Merged
joshdover added a commit that referenced this pull request Dec 12, 2019
@joshdover
[7.x] Add getStartServices API (#50231) (#52943)
12153e5
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 12, 2019

💚 Build Succeeded

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@joshdover joshdover mentioned this pull request Dec 19, 2019
Merged
7 tasks
@lukasolson lukasolson mentioned this pull request Jan 6, 2020
Closed
@pgayvallet pgayvallet mentioned this pull request Jan 17, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pgayvallet pgayvallet pgayvallet approved these changes

Assignees

No one assigned

Labels

Feature:New Platform release_note:plugin_api_changes Contains a Plugin API changes section for the breaking plugin API changes section. Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Replace client-side context with getStartServices API

3 participants

@joshdover @elasticmachine @pgayvallet