[Maps] Introduce fields#50044
Merged
thomasneirynck merged 132 commits intoelastic:masterfrom Nov 21, 2019
Merged
Conversation
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
nreese
reviewed
Nov 20, 2019
x-pack/legacy/plugins/maps/public/layers/sources/ems_file_source/update_source_editor.js
Outdated
Show resolved
Hide resolved
...gacy/plugins/maps/public/layers/styles/vector/components/legend/style_property_legend_row.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/components/vector_style_editor.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/components/vector_style_editor.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/properties/style_property.js
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
x-pack/legacy/plugins/maps/public/layers/styles/vector/vector_style.js
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
nreese
approved these changes
Nov 21, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
Nice job getting this one across the finish line. This is a great refactor that will make it much easier to implement a lot of cool features.
LGTM
code review, tested in chrome
Contributor
💚 Build Succeeded |
Contributor
💚 Build Succeeded |
thomasneirynck
added a commit
to thomasneirynck/kibana
that referenced
this pull request
Nov 21, 2019
This introduces the `AbstractField` class and its implementations. Their use replace the ad-hoc object literals that were used to pass around field-level metadata in joins, metrics, styles, and tooltips.
thomasneirynck
added a commit
that referenced
this pull request
Nov 22, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Introduces field interface
Introduces 4 field types (
x-pack/legacy/plugins/maps/public/layers/fields)EMSRegionField: fields from EMSESAggField: fields that wrap results of aggs (e.g. geogrid-sources, or term-join metrics)ESDocField: fields from ES-index patternKibanaRegionField: fields from configured geojson in the .ymlIntroduce fields as top-level concept.
Fields are scattered and inconsistent throughout the code-base right now, wrt. display, config, and typing.
Fieldsshould be used consistently for:-- left field definitions
-- right field definitions
-- for grid source
-- for pewpew source
Fields are source-dependent
Later, fields should also be used for