Fixing bugs in the Shareable Runtime#49965
Merged
crob611 merged 5 commits intoelastic:masterfrom Nov 12, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
Contributor
|
Code look good, but I'm still getting an error when running in IE11
And the offending lines of code look to be |
Contributor
Author
|
I think that's coming from https://github.com/elastic/kibana/blob/master/src/plugins/expressions/public/functions/font.ts#L29 @streamich It looks like you have an impending IE11 bug with your NP migration. #47810 @crob611 this is likely not a problem in 7.5, which is where this is targeted. I'm running out of time before my leave, so if I can't sort this by tomorrow, I'll need you to arrange for someone to take over. cc: @timductive Honestly, I think this is ok as it is, and we can open a new issue against expressions in NP in 8.0... at least, that's where my head's at at the moment. Let me know. |
crob611
approved these changes
Nov 3, 2019
Contributor
crob611
left a comment
There was a problem hiding this comment.
Looks good.
Reverted out that commit that introduced that error in font that I was seeing and everything looks great.
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
Contributor
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
This was referenced Nov 12, 2019
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Nov 12, 2019
* Fixing bugs in the Shareable Runtime * Updating snapshots
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Nov 12, 2019
* Fixing bugs in the Shareable Runtime * Updating snapshots
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
* upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Nov 12, 2019
…skip ci] * upstream/master: Move table-list-view to kibana-react (elastic#50046) [ML] Stats bar for data frame analytics (elastic#49464) [ML] Make navigation in tests more stable (elastic#50132) Migrate authorization subsystem to the new platform. (elastic#46145) Bugfix: Interpreter conversion of string to number should throw on NaN elastic#27788 (elastic#50063) Update dependency @elastic/charts to v14 (elastic#49947) [ML] Adding cloud specific ML node warning (elastic#50139) Fixing bugs in the Shareable Runtime (elastic#49965) Revert router base name for Uptime plugin to use hash in default path. (elastic#50095) Ability to have telemetry always opted in (elastic#49798) Add "Get Help" and "Kibana Feedback" links to the help popover (elastic#49797) Removes references to Elasticsearch mapping types (elastic#47610) [skip-ci] Replace coordinate map in Kibana getting started docs with Maps (elastic#50167) [ML] Indicate missing required privileges for import in File Data Viz (elastic#50147) [SIEM][Detection Engine] Removes technical debt and minor bug fixes (elastic#50111)
crob611
pushed a commit
that referenced
this pull request
Nov 13, 2019
crob611
pushed a commit
that referenced
this pull request
Nov 13, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A collection of bug fixes for the Shareable Runtime.
Fixes: #49577 #49576
charseton the page. Since we can't ensure consumers set acharset, we should use thehasEmptyLabelSpaceproperty.tinymathneeds to be forced to thees5version for IE11, (see [Canvas]tinymathpreventing Kibana from starting in IE11 #38857, [tinymath] use the es5 build #38911)flex-shrinkapplied to avoid overlap.DOCTYPE.