increase type check memory for x-pack to 4GB#49255
Merged
spalger merged 1 commit intoelastic:masterfrom Oct 25, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
brianseeders
approved these changes
Oct 24, 2019
Contributor
brianseeders
left a comment
There was a problem hiding this comment.
LGTM
the instances that run intake have 16GB memory, so should be okay
tylersmalley
approved these changes
Oct 24, 2019
Contributor
💚 Build Succeeded |
This was referenced Oct 25, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 25, 2019
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Oct 25, 2019
spalger
pushed a commit
that referenced
this pull request
Oct 25, 2019
spalger
pushed a commit
that referenced
this pull request
Oct 25, 2019
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed OOMs when type checking the x-pack project in #48026, and increased the memory for the x-pack project there but it's now happening outside of that PR too, and with some consistency.
This is probably the last reasonable memory increase we should allow, and instead we really need to escalate efforts to break x-pack up into separate projects. Typed, built, etc. separately.