Skip to content

Add filebeat notice#49065

Merged
cachedout merged 11 commits intoelastic:masterfrom
cachedout:filebeat_notice
Nov 14, 2019
Merged

Add filebeat notice#49065
cachedout merged 11 commits intoelastic:masterfrom
cachedout:filebeat_notice

Conversation

@cachedout
Copy link
Copy Markdown
Contributor

@cachedout cachedout commented Oct 23, 2019 •
edited
Loading

Summary

Small docs change. Refs #48929

Preview: http://kibana_49065.docs-preview.app.elstc.co/guide/en/kibana/master/monitor-troubleshooting.html

Warning: This should not be merged until #49065 is in

@cachedout cachedout added v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 v7.6.0 labels Oct 23, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 23, 2019

💚 Build Succeeded

chrisronline
chrisronline reviewed Oct 23, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
lcawl
lcawl reviewed Oct 29, 2019
View reviewed changes
cachedout and others added 3 commits October 29, 2019 08:22
@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
ef03256 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
03634a5 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
6f7af1c 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💔 Build Failed

@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
9542aa8 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💔 Build Failed

cachedout and others added 2 commits October 29, 2019 08:23
@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
ba100ec 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@cachedout @lcawl
Update docs/user/monitoring/monitoring-troubleshooting.asciidoc
f0fd58a 
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💔 Build Failed

@cachedout
Copy link
Copy Markdown
Contributor Author

cachedout commented Oct 29, 2019 •
edited
Loading

Thank you very much @lcawl ! I have applied your suggestions. I am just waiting to hear back from @chrisronline on the question above and then we can get this merged.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 29, 2019

Pinging @elastic/kibana-docs (Team:Docs)

lcawl
lcawl approved these changes Oct 29, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisronline
Copy link
Copy Markdown
Contributor

chrisronline commented Nov 11, 2019

ping on this

@cachedout
Copy link
Copy Markdown
Contributor Author

cachedout commented Nov 12, 2019

@chrisronline Thanks for the ping. I somehow missed your reply earlier. Apologies for that! I have updated this PR to better reflect the error message and it is ready for re-review.

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 12, 2019

💔 Build Failed

chrisronline
chrisronline approved these changes Nov 12, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cachedout
Copy link
Copy Markdown
Contributor Author

cachedout commented Nov 12, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 12, 2019

💔 Build Failed

@chrisronline
Copy link
Copy Markdown
Contributor

chrisronline commented Nov 13, 2019

@elasticmachine merge upstream

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2019

💔 Build Failed

@chrisronline
Copy link
Copy Markdown
Contributor

chrisronline commented Nov 13, 2019

@elasticmachine merge upstream

@cachedout cachedout mentioned this pull request Nov 13, 2019
Merged
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2019

💚 Build Succeeded

@chrisronline
Copy link
Copy Markdown
Contributor

chrisronline commented Nov 14, 2019

Warning: This should not be merged until #49065 is in

Shouldn't this be merged first? Then we update #49065 to include the link to doc?

@cachedout
Copy link
Copy Markdown
Contributor Author

cachedout commented Nov 14, 2019

@chrisronline I really just meant that they should be merged around the same time ideally. I can go ahead and merge this now. Thanks for the ping!

@cachedout cachedout merged commit 30a70b3 into elastic:master Nov 14, 2019
@cachedout cachedout deleted the filebeat_notice branch November 14, 2019 17:03
jloleysens added a commit to jloleysens/kibana that referenced this pull request Nov 15, 2019
@jloleysens
Merge branch 'master' of github.com:elastic/kibana into fix/grokdebug…
5fd5d54 
…ger-ace-theme

* 'master' of github.com:elastic/kibana: (54 commits)
  [ML] Fixes word wrap in Overview page sidebar on IE (elastic#50668)
  Upgrade to TypeScript 3.7.2 (elastic#47188)
  fix: hide 'edit' button for mobile for dashboards (elastic#50639)
  fixes conditional links tests (elastic#50642)
  [SIEM] Fix IE11 timeline drag and drop issue (elastic#50528)
  [SIEM] Add SavedQuery in Timeline (elastic#49813)
  chore(NA): remove code plugin from codeowners (elastic#50451)
  [DOCS] Adds documentation on telemetry settings (elastic#50739)
  [Logs UI] Add IE11-specific CSS fixes for anomalies table (elastic#49980)
  [DOCS][SIEM]: Change Kibana advanced settings to match UI (elastic#50679)
  Change URLs for support menu (elastic#50700)
  [Reporting] Remove any types and references to Hapi (elastic#49250)
  [DOCS] Adds note about backups to Upgrade doc (elastic#50525)
  [Logs UI] Improve infra plugin compatibility with TS 3.7 (elastic#50491)
  [Task manager] Adds ensureScheduling api to allow safer rescheduling of existing tasks (elastic#50232)
  [DOCS] Adds link to content security policy doc (elastic#50698)
  Remove duplicate but in error message (elastic#50530)
  [ML] DF Analytics: Ensure creation flyout can be opened when no jobs exist (elastic#50417)
  Add filebeat notice (elastic#49065)
  [Monitoring] De-duplicate pipeline ids based on the ephemeral_id changing (elastic#49978)
  ...

# Conflicts:
#	x-pack/legacy/plugins/grokdebugger/public/components/grok_debugger/brace_imports.ts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lcawl lcawl lcawl approved these changes

+1 more reviewer

@chrisronline chrisronline chrisronline approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Feature:Stack Monitoring release_note:skip Skip the PR/issue when compiling release notes Team:Docs v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cachedout @elasticmachine @chrisronline @lcawl