[ML] Transform: Fix permissions. Fix error messages.#49025
Merged
walterra merged 5 commits intoelastic:masterfrom Oct 23, 2019
Merged
[ML] Transform: Fix permissions. Fix error messages.#49025walterra merged 5 commits intoelastic:masterfrom
walterra merged 5 commits intoelastic:masterfrom
Conversation
3 tasks
Contributor
Author
|
retest |
Contributor
💔 Build Failed |
Contributor
|
Pinging @elastic/ml-ui (:ml) |
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Oct 23, 2019
- Updated internal permissions docs. - Fixes regression to change data_frame to transform for privileges. - Fixes error messages for wizard source table. An error triggered by Elasticsearch would not properly be passed through, just a generic JS error would be reported. Now the error for both source table and pivot preview get passed through. - Fixes correctly reporting an error if the wizard fails to create the transform, previously a success toast would show in any case. - The screenshot below also shows the fix for elastic#46434: A snipped of the full error message is now shown within the toast.
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Oct 23, 2019
- Updated internal permissions docs. - Fixes regression to change data_frame to transform for privileges. - Fixes error messages for wizard source table. An error triggered by Elasticsearch would not properly be passed through, just a generic JS error would be reported. Now the error for both source table and pivot preview get passed through. - Fixes correctly reporting an error if the wizard fails to create the transform, previously a success toast would show in any case. - The screenshot below also shows the fix for elastic#46434: A snipped of the full error message is now shown within the toast.
walterra
added a commit
that referenced
this pull request
Oct 24, 2019
- Updated internal permissions docs. - Fixes regression to change data_frame to transform for privileges. - Fixes error messages for wizard source table. An error triggered by Elasticsearch would not properly be passed through, just a generic JS error would be reported. Now the error for both source table and pivot preview get passed through. - Fixes correctly reporting an error if the wizard fails to create the transform, previously a success toast would show in any case. - The screenshot below also shows the fix for #46434: A snipped of the full error message is now shown within the toast.
walterra
added a commit
that referenced
this pull request
Oct 24, 2019
- Updated internal permissions docs. - Fixes regression to change data_frame to transform for privileges. - Fixes error messages for wizard source table. An error triggered by Elasticsearch would not properly be passed through, just a generic JS error would be reported. Now the error for both source table and pivot preview get passed through. - Fixes correctly reporting an error if the wizard fails to create the transform, previously a success toast would show in any case. - The screenshot below also shows the fix for #46434: A snipped of the full error message is now shown within the toast.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46434.
Part of #48904.
data_frametotransformfor privileges.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers