[ML] Disable exclude frequent if no by or over has been selected#48625
Merged
jgowdyelastic merged 2 commits intoelastic:masterfrom Oct 18, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
approved these changes
Oct 18, 2019
Contributor
peteharverson
left a comment
There was a problem hiding this comment.
One typo, otherwise LGTM
| }, []); | ||
|
|
||
| useEffect(() => { | ||
| // wipe the exclude frequent choice if the select has beed disabled |
Contributor
There was a problem hiding this comment.
Typo! Should be been
walterra
approved these changes
Oct 18, 2019
Contributor
💚 Build Succeeded |
This was referenced Oct 18, 2019
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Oct 18, 2019
…stic#48625) * [ML] Disable exclude frequent if no by or over has been selected * fixing typo in comment
jgowdyelastic
added a commit
to jgowdyelastic/kibana
that referenced
this pull request
Oct 18, 2019
…stic#48625) * [ML] Disable exclude frequent if no by or over has been selected * fixing typo in comment
jgowdyelastic
added a commit
that referenced
this pull request
Oct 18, 2019
) (#48641) * [ML] Disable exclude frequent if no by or over has been selected * fixing typo in comment
jgowdyelastic
added a commit
that referenced
this pull request
Oct 18, 2019
) (#48640) * [ML] Disable exclude frequent if no by or over has been selected * fixing typo in comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If no
byoroverfield has been selected, theexclude frequentselect should be disabled.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers