[Discover] Fix console Range Error#48608
Merged
kertal merged 1 commit intoelastic:masterfrom Oct 18, 2019
Merged
Conversation
Contributor
💚 Build Succeeded |
Contributor
|
Pinging @elastic/kibana-app (Team:KibanaApp) |
Contributor
|
Is this still a problem? On Master, the problem has been resolved by #47933 Update: looks like the errors are still present. Sorry for the noise |
Member
Author
|
You could review it , then it would be gone :) |
Contributor
looking at it now |
nreese
approved these changes
Oct 18, 2019
Contributor
nreese
left a comment
There was a problem hiding this comment.
lgtm
code review, tested in chrome
Member
Author
|
thanx @nreese, sorry for being pushy |
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Oct 18, 2019
kertal
added a commit
to kertal/kibana
that referenced
this pull request
Oct 18, 2019
kertal
added a commit
that referenced
this pull request
Oct 18, 2019
kertal
added a commit
that referenced
this pull request
Oct 18, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix multiple RangeErrors in console, when unfolding a list entry:
Note: The reason for this error, some changes in Indexpattern, and a reactDirective using it and
watchDepthnot set toreference.Fixes: #48586
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenarios- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately