Skip to content

[ML] Fixing empty validation list in wizards#48553

Merged
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fixing-empty-validation-list-in-wizards
Oct 18, 2019
Merged

[ML] Fixing empty validation list in wizards#48553
jgowdyelastic merged 3 commits intoelastic:masterfrom
jgowdyelastic:fixing-empty-validation-list-in-wizards

Conversation

@jgowdyelastic
Copy link
Copy Markdown
Member

@jgowdyelastic jgowdyelastic commented Oct 17, 2019

Shows a generic message if the validation list is empty.

image

@jgowdyelastic jgowdyelastic added bug Fixes for quality problems that affect the customer experience review :ml v8.0.0 v7.5.0 v7.6.0 labels Oct 17, 2019
@jgowdyelastic jgowdyelastic requested a review from a team as a code owner October 17, 2019 16:33
@jgowdyelastic jgowdyelastic self-assigned this Oct 17, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/ml-ui (:ml)

Copy link
Copy Markdown
Contributor

@walterra walterra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgowdyelastic jgowdyelastic added non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes labels Oct 17, 2019
Copy link
Copy Markdown
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@jgowdyelastic jgowdyelastic merged commit 3c68b0b into elastic:master Oct 18, 2019
@jgowdyelastic jgowdyelastic deleted the fixing-empty-validation-list-in-wizards branch October 18, 2019 09:37
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Oct 18, 2019
* [ML] Fixing empty validation list in wizards

* updating translations

* updating snapshot
jgowdyelastic added a commit to jgowdyelastic/kibana that referenced this pull request Oct 18, 2019
* [ML] Fixing empty validation list in wizards

* updating translations

* updating snapshot
jgowdyelastic added a commit that referenced this pull request Oct 18, 2019
* [ML] Fixing empty validation list in wizards

* updating translations

* updating snapshot
jgowdyelastic added a commit that referenced this pull request Oct 18, 2019
* [ML] Fixing empty validation list in wizards

* updating translations

* updating snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes for quality problems that affect the customer experience :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes review v7.5.0 v7.6.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants