Preserve script load/execution order#48465
Merged
tylersmalley merged 2 commits intoelastic:masterfrom Oct 17, 2019
Merged
Conversation
We need to either disable async loading, or defer exection. In IE11, we're running into an issue where the logout page is executing before the vendors file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
I patched my local 7.5.0 snapshot build with the change from this PR and it worked. I logged in and out on IE11 5 times with no problem. |
Contributor
💚 Build Succeeded |
jbudz
approved these changes
Oct 16, 2019
Contributor
jbudz
left a comment
There was a problem hiding this comment.
Works for me.
@joshdover did you have any concerns here?
mistic
reviewed
Oct 16, 2019
mistic
approved these changes
Oct 16, 2019
Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
Contributor
💚 Build Succeeded |
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 17, 2019
We need to either disable async loading, or defer exection. In IE11, we're running into an issue where the logout page is executing before the vendors file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 17, 2019
We need to either disable async loading, or defer exection. In IE11, we're running into an issue where the logout page is executing before the vendors file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
This was referenced Oct 17, 2019
tylersmalley
added a commit
to tylersmalley/kibana
that referenced
this pull request
Oct 17, 2019
We need to either disable async loading, or defer exection. In IE11, we're running into an issue where the logout page is executing before the vendors file. Signed-off-by: Tyler Smalley <tyler.smalley@elastic.co>
tylersmalley
added a commit
that referenced
this pull request
Oct 17, 2019
tylersmalley
added a commit
that referenced
this pull request
Oct 17, 2019
tylersmalley
added a commit
that referenced
this pull request
Oct 17, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to either disable async loading, or defer execution. In IE11, we're running into an issue where the logout page is executing before the vendors file.
Fixes #46943
The above was tested averaging out five requests. Cache was disabled using a 40 ms, 28 Mb/s down, 11 Mb/s up network throttling profile.