main and nav landmark a11y fixes#48381
Merged
myasonik merged 4 commits intoelastic:masterfrom Oct 18, 2019
Merged
Conversation
Contributor
💔 Build Failed
|
722d85a to
f0dedb9
Compare
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
afgomez
reviewed
Oct 18, 2019
x-pack/legacy/plugins/infra/public/components/navigation/app_navigation.tsx
Outdated
Show resolved
Hide resolved
Contributor
💚 Build Succeeded |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EUI 14.5.0 introduced some new semantics so I updated Kibana to match. Namely,
EuiPageBodynow is amaintag so I removed Kibana's overarchingmainand addedmaintag to individual pages that weren't usingEuiPageBody.While checking for landmarks on pages, I also fixed up
navlandmark names because they're quite important.Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] Unit or functional tests were updated or added to match the most common scenariosFor maintainers