Skip to content

main and nav landmark a11y fixes#48381

Merged
myasonik merged 4 commits intoelastic:masterfrom
myasonik:a11y-update-for-eui-14.5
Oct 18, 2019
Merged

main and nav landmark a11y fixes#48381
myasonik merged 4 commits intoelastic:masterfrom
myasonik:a11y-update-for-eui-14.5

Conversation

@myasonik
Copy link
Copy Markdown
Contributor

Summary

EUI 14.5.0 introduced some new semantics so I updated Kibana to match. Namely, EuiPageBody now is a main tag so I removed Kibana's overarching main and added main tag to individual pages that weren't using EuiPageBody.

While checking for landmarks on pages, I also fixed up nav landmark names because they're quite important.

Checklist

Use strikethroughs to remove checklist items you don't feel are applicable to this PR.

- [ ] This was checked for cross-browser compatibility, including a check against IE11

For maintainers

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@myasonik myasonik force-pushed the a11y-update-for-eui-14.5 branch from 722d85a to f0dedb9 Compare October 16, 2019 11:03
Copy link
Copy Markdown
Contributor

@rudolf rudolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Core changes LGTM

Copy link
Copy Markdown
Contributor

@sorenlouv sorenlouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apm changes lgtm

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@sgrodzicki sgrodzicki self-requested a review October 18, 2019 09:44
Copy link
Copy Markdown

@sgrodzicki sgrodzicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs & Metrics UI LGTM

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@myasonik myasonik merged commit 894fff0 into elastic:master Oct 18, 2019
@myasonik myasonik deleted the a11y-update-for-eui-14.5 branch October 18, 2019 13:41
myasonik pushed a commit that referenced this pull request Oct 21, 2019
* main and nav landmark a11y fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants