[SIEM] Add Authentications histogram#48260
Conversation
|
Pinging @elastic/siem (Team:SIEM) |
💔 Build Failed |
…entications-histogram
💚 Build Succeeded |
| import { i18n } from '@kbn/i18n'; | ||
|
|
||
| export const AUTHENTICATIONS_COUNT = i18n.translate( | ||
| 'xpack.siem.authenticationsOverTime.authenticationCount', |
There was a problem hiding this comment.
Could be xpack.siem.authenticationsOverTime.authenticationCountTitle.
There's a specific naming rules we can follow here:
https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/GUIDELINE.md#message-types
|
Nicely done, thank you! Played around with it and found the legend shows incorrectly when only once group of data is given. This might be an existing problem, but given that this case seems to be very common for auth histogram, I would prefer to fix it in this PR. Besides that all looks good! |
💚 Build Succeeded |
angorayc
left a comment
There was a problem hiding this comment.
Summary some feedback from @markov00 for the problem we have:
That happens because when using splitSeries the chart determine the number of series in the data and use the value from the splitted groups, in your case the value of your g as the name of the series. If only one series exist on the chart, then we use the name or the id of the series.
We can work around this via
- Add the missing data: { x: 1571290200000, y: null, g: 'authentication_success' } or
- What we are doing in this PR or
- Create every group a series (Like what we are doing for barcharts in KPIs)
Since they've got a ticket elastic/elastic-charts#245,
I think we can comment this ticket in the code and have a proper fix for it later
💚 Build Succeeded |
|
Awesome, LGTM, thank you so much! |
💚 Build Succeeded |
💚 Build Succeeded |
|
Hey Patryk, |
|
I’m happy to have a temporary solution here in this PR, and submit another one for a generic solution for it. |
…entications-histogram # Conflicts: # x-pack/legacy/plugins/siem/public/pages/hosts/details/index.tsx
💚 Build Succeeded |
Summary
https://github.com/elastic/siem-team/issues/467
Add authentications histogram to
hosts/host detailspage (#42461)The histogram shows
Will add a dropdown so users can switch between total authentications count, top users/sources/destinations.
mockup: https://www.figma.com/file/YvAwDnS860sgOUTdLemnuF/Histograms?node-id=14%3A3468
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately