[Canvas] Disable embeddables in canvas#48102
Merged
crob611 merged 4 commits intoelastic:masterfrom Oct 15, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
clintandrewhall
approved these changes
Oct 14, 2019
| import { savedMap } from './saved_map'; | ||
| import { savedSearch } from './saved_search'; | ||
| import { savedVisualization } from './saved_visualization'; | ||
| // TODO: Re-Enable once we get filtering from embeddables figured out |
Contributor
There was a problem hiding this comment.
nit: refer to the Github issue in the comment... if there isn't one, let's create one.
| <AssetManager /> | ||
| </EuiFlexItem> | ||
| {/* | ||
| Disabling embeddables until we figure out filters |
Contributor
There was a problem hiding this comment.
Same. And tag with TODO. Consider TODO: elastic/kibana#12345 Disabling pending filters work
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Oct 15, 2019
* Disable embeddables in canvas
crob611
pushed a commit
that referenced
this pull request
Oct 15, 2019
crob611
pushed a commit
to crob611/kibana
that referenced
this pull request
Oct 17, 2019
This reverts commit 12a4439.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We didn't get the filtering stuff figured out this cycle, but the initial embeddable code got merged to 7.x, so this PR is simply commenting out the embeddable expression functions and the button for adding an embeddable to a workpad. These will be uncommented out in the PR that will enable the filters with appropriate filtering.