[Uptime] Update snapshot counts by justinkambic · Pull Request #48035 · elastic/kibana

justinkambic · 2019-10-11T21:13:33Z

Summary

Resolves #47376.

~~Code is WIP.~~

The goal of this patch is to utilize the monitor iterator to ensure that the snapshot counts we're showing the user correspond to the values in the monitor list.

In addition to updating how we compute these values, we're moving the querying code from the existing GQL schema to a REST endpoint with io-ts-generated typing for validation. Additionally, we've begun a state management migration from internal component state and context reliance to a dedicated Redux-powered solution. As a result, there're some added functions around data fetching, state reduction, and action dispatching. It also resulted in the Snapshot component becoming a connected container.

Testing this PR

Start up one or more Heartbeat locations and run this patch
Ensure that the counts in the Snapshot view at the top of the Overview page correspond to the count of each status type of monitor shown in the table
When you filter your environment, ensure that the filters you're applying result in the same numeric changes between the monitor list and the snapshot count

The goal here is to ensure that the counts we show our users correspond to the actual data we're displaying in our table.

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-10-11T21:13:35Z

Pinging @elastic/uptime (Team:uptime)

elasticmachine · 2019-10-11T22:23:42Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 34f0a771628d1ede128f5ea19dd7defa9a2be67a

justinkambic · 2019-11-11T13:51:22Z

@elasticmachine merge upstream

elasticmachine · 2019-11-11T15:14:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 81088d9b258f95726c499c913fd1d8ef76c01cf5

elasticmachine · 2019-11-11T23:04:13Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 23b29e5feaf08bb86c0c8cdb5dd858e2898b99a2

elasticmachine · 2019-11-12T01:14:45Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: f3ff1357a540f27a1aa07d4b972c8ec661a77e13

elasticmachine · 2019-11-12T22:49:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 891b6f499c51082dbfbf46a0d1aaa9fa82d6db9d

elasticmachine · 2019-11-13T05:14:49Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: b01464203fe860801275a0400fe723f42c05192a

elasticmachine · 2019-11-14T05:00:29Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: ecd73149643e0b6a978cc530886f0797d357d587

elasticmachine · 2019-11-14T20:25:23Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: a2952f98ce98250c23830b2c92946978f168c77d

elasticmachine · 2019-11-14T21:49:54Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 6d0776191d6523e9587594497bb0c9fa52f1d422

elasticmachine · 2019-11-25T22:30:16Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 27966f8

elasticmachine · 2019-11-25T22:57:52Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: e353bc9

shahzad31

looks good, are we going to do those label changes in this PR or you want to handle that separately?
We discussed at that top, that i should says "All selected monitors are up".

"0/2 of selected monitors are up".

justinkambic · 2019-11-26T16:04:36Z

looks good, are we going to do those label changes in this PR or you want to handle that separately?
We discussed at that top, that i should says "All selected monitors are up".

"0/2 of selected monitors are up".

@shahzad31 I think I'd prefer not to add any more code to this patch as it's holding up some more PR's downstream. If you're ok with it I'll create another enhancement issue to add that, will be a tiny change.

elasticmachine · 2019-11-26T17:40:31Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: fa17361

justinkambic · 2019-11-26T17:56:22Z

@elasticmachine merge upstream

justinkambic · 2019-11-26T18:33:36Z

@shahzad31 I added a follow-up issue for heading text here: elastic/uptime#120

shahzad31

LGTM, WFG !!

elasticmachine · 2019-11-26T19:08:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 69d2a38

* Add snapshot count function that uses monitor iterator class. * Add js-doc comment. * Add snapshot count route. * Start adding snapshot state management. * Commit changes that were missed in previous. * Finish implementing snapshot count redux code. * Add basePath setter and type to ui state. * Dispatch basePath set action on app render. * Replace GQL-powered Snapshot export with Redux/Rest-powered version. * Extract presentational element to dedicated component. * Update broken test. * Rename action. * Add comments to clarify adapter function. * Remove obsolete code. * Add ui state field to store for tracking when app refreshes. * Make snapshot component refresh on global refresh via redux state. * Remove obsolete @ts-igore. * Alphabetize imports. * Port functional test fixture to REST test. * Delete snapshot GQL query. * Update API test fixtures to match new snapshot count REST response shape. * Update Snapshot count type check to be stricter. * Add tests for Snapshot API call. * Rename new test file from tsx to ts, it has no JSX. * Add tests for snapshot reducer. * Add tests for UI reducer. * Add tests for selectors. * Delete unused test file. * Move snapshot getter and map/reduce logic to dedicated helper function. * Add test for snapshot helper function. * Export type from module. * Rename outdated snapshot file. * Add action creator for fetch success. * Reorganize ui actions file. * Update snapshot effect to put error when input params are not valid. * Simplify typing code for a function. * Simplify snapshot count reduction. * Rename a function. * Rewrite a function to increase code clarity. * Remove duplicated interface. * Add very high ceiling for snapshot count iteration. * Update broken test assertion.

justinkambic · 2019-12-04T15:03:07Z

Backported to:
7.x/7.6.0 97d2fa6
#52137

justinkambic added WIP Work in progress v8.0.0 Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability v7.5.0 polish labels Oct 11, 2019

justinkambic self-assigned this Oct 11, 2019

justinkambic mentioned this pull request Oct 22, 2019

[Uptime] Add empty donut state #48583

Merged

7 tasks

justinkambic added v7.6.0 and removed v7.5.0 labels Oct 30, 2019

justinkambic force-pushed the uptime_snapshot-counts branch from abcd5d7 to 23b29e5 Compare November 11, 2019 21:53

justinkambic removed the WIP Work in progress label Nov 12, 2019

justinkambic marked this pull request as ready for review November 12, 2019 00:01

justinkambic added the release_note:enhancement label Nov 12, 2019

justinkambic requested a review from shahzad31 November 12, 2019 00:02

justinkambic force-pushed the uptime_snapshot-counts branch from f3ff135 to 891b6f4 Compare November 12, 2019 21:21

justinkambic force-pushed the uptime_snapshot-counts branch from 891b6f4 to b014642 Compare November 13, 2019 04:01

justinkambic force-pushed the uptime_snapshot-counts branch from b014642 to ecd7314 Compare November 14, 2019 03:42

justinkambic force-pushed the uptime_snapshot-counts branch from ecd7314 to a2952f9 Compare November 14, 2019 19:09

justinkambic mentioned this pull request Nov 14, 2019

Snapshot counts ignore supplied filters elastic/uptime#103

Closed

justinkambic added 6 commits November 25, 2019 14:42

Merge branch 'master' into uptime_snapshot-counts

e226ced

Simplify snapshot count reduction.

3139295

Rename a function.

0f5ba99

Rewrite a function to increase code clarity.

887d9fb

Remove duplicated interface.

27966f8

Add very high ceiling for snapshot count iteration.

e353bc9

justinkambic mentioned this pull request Nov 25, 2019

[Uptime] Make backend iterator class support an infinite size option elastic/uptime#119

Closed

justinkambic requested review from andrewvc and shahzad31 November 25, 2019 21:46

shahzad31 reviewed Nov 26, 2019

View reviewed changes

Update broken test assertion.

fa17361

Merge branch 'master' into uptime_snapshot-counts

69d2a38

justinkambic mentioned this pull request Nov 26, 2019

[Uptime] [Uptime] Make overview heading handle filtered states better elastic/uptime#120

Closed

shahzad31 approved these changes Nov 26, 2019

View reviewed changes

justinkambic merged commit ce16609 into elastic:master Nov 27, 2019

justinkambic added the backport pending label Nov 27, 2019

justinkambic mentioned this pull request Dec 3, 2019

[7.x] [Uptime] Update snapshot counts (#48035) #52137

Merged

justinkambic deleted the uptime_snapshot-counts branch December 4, 2019 15:03

justinkambic removed the backport pending label Dec 4, 2019

Conversation

justinkambic commented Oct 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Testing this PR

Checklist

For maintainers

Uh oh!

elasticmachine commented Oct 11, 2019

Uh oh!

elasticmachine commented Oct 11, 2019

💔 Build Failed

Uh oh!

justinkambic commented Nov 11, 2019

Uh oh!

elasticmachine commented Nov 11, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 11, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 12, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 12, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 13, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 14, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 14, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Nov 25, 2019

💔 Build Failed

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

justinkambic commented Nov 26, 2019

Uh oh!

elasticmachine commented Nov 26, 2019

💔 Build Failed

Uh oh!

justinkambic commented Nov 26, 2019

Uh oh!

justinkambic commented Nov 26, 2019

Uh oh!

shahzad31 left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 26, 2019

💚 Build Succeeded

Uh oh!

justinkambic commented Dec 4, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

justinkambic commented Oct 11, 2019 •

edited

Loading