Skip to content

[SIEM] type fix#47708

Merged
stephmilovic merged 3 commits intoelastic:masterfrom
stephmilovic:dns-type-fix
Oct 10, 2019
Merged

[SIEM] type fix#47708
stephmilovic merged 3 commits intoelastic:masterfrom
stephmilovic:dns-type-fix

Conversation

@stephmilovic
Copy link
Copy Markdown
Contributor

Summary

Remove unused type that was throwing errors because it had the same name as an actual type, NetworkDnsData

@stephmilovic stephmilovic added Team:SIEM v8.0.0 release_note:skip Skip the PR/issue when compiling release notes v7.5.0 labels Oct 9, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/siem (Team:SIEM)

@stephmilovic stephmilovic requested a review from XavierM October 9, 2019 14:50
@timroes
Copy link
Copy Markdown
Contributor

timroes commented Oct 9, 2019

There is also NetworkTopNFlowData which is duplicated in there. Can this be removed too? Otherwise we should rename the import, so it doesn't clash.

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Copy Markdown
Contributor

💔 Build Failed

@timroes timroes mentioned this pull request Oct 9, 2019
15 tasks
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Copy link
Copy Markdown
Contributor

@XavierM XavierM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephmilovic stephmilovic merged commit 8dc80a2 into elastic:master Oct 10, 2019
@stephmilovic stephmilovic deleted the dns-type-fix branch October 10, 2019 14:03
stephmilovic added a commit to stephmilovic/kibana that referenced this pull request Oct 10, 2019
* type fix

* remove other unused type

* rm unused var
stephmilovic added a commit that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:skip Skip the PR/issue when compiling release notes Team:SIEM v7.5.0 v8.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants