[Canvas] Prepare TS for 3.7 upgrade#47703
Merged
timroes merged 1 commit intoelastic:masterfrom Oct 10, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/kibana-canvas (Team:Canvas) |
Contributor
💚 Build Succeeded |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Oct 10, 2019
timroes
pushed a commit
that referenced
this pull request
Oct 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a couple of TS issues, that would occur ones we update to TS 3.7 (#47188). Since we are trying to update to TS 3.7.0 in time, I am already trying to fix those issues now. The main issue here was, that we cannot have imports with the same name as exports anymore (this was actually a bug that that ever worked).
For QA: This PR doesn't introduce any functional change.