[DOCS] Include server.cors configuration settings#47701
Conversation
Include `server.cors` configuration settings
|
Pinging @elastic/kibana-operations (Team:Operations) |
|
Pinging @elastic/kibana-platform (Team:Platform) |
|
Pinging @elastic/kibana-docs (Team:Docs) |
💔 Build Failed |
docs/setup/settings.asciidoc
Outdated
|
|
||
| [[server-cors]]`server.cors:`:: *Default: `false`* Set to `true` to enable CORS support, this setting is required in order to configure `server.cors.origin`. | ||
|
|
||
| `server.cors.origin:`:: *Default: none* Used to specify origins, "origin" must be an array. This setting requires `server.cors: true` set. Use `server.cors.origin: ["*"]` to accept all origins. |
There was a problem hiding this comment.
I'm actually not sure the server.cors.origins feature is implemented in production mode. We still have an open issue about this: #16714
Someone will need to verify, I may have some time later today.
KOTungseth
left a comment
There was a problem hiding this comment.
Thank you so much for pushing this PR! I have a few comments and suggestions, but other than these, this looks great.
docs/setup/settings.asciidoc
Outdated
| if it should remove the basePath from requests it receives, and to prevent a | ||
| deprecation warning at startup. This setting cannot end in a slash (`/`). | ||
|
|
||
| [[server-cors]]`server.cors:`:: *Default: `false`* Set to `true` to enable CORS support, this setting is required in order to configure `server.cors.origin`. |
There was a problem hiding this comment.
Not critical, but could we split this into two sentences? For example:
Set to true to enable CORS support. This setting is required to configure server.cors.origin.
docs/setup/settings.asciidoc
Outdated
|
|
||
| [[server-cors]]`server.cors:`:: *Default: `false`* Set to `true` to enable CORS support, this setting is required in order to configure `server.cors.origin`. | ||
|
|
||
| `server.cors.origin:`:: *Default: none* Used to specify origins, "origin" must be an array. This setting requires `server.cors: true` set. Use `server.cors.origin: ["*"]` to accept all origins. |
There was a problem hiding this comment.
I think this could benefit from some reformatting. What do you think about:
Specifies origins. "origin" must be an array. To use this setting, you must set server.cors to true. To accept all origins, use server.cors.origin: ["*"].
Update formatting in the `server.cors` configuration settings
💔 Build Failed |
|
@elasticmachine update branch |
💔 Build Failed |
|
@elasticmachine merge upstream |
|
Thank you @spalger and @KOTungseth. I'll |
Include `server.cors` configuration settings -- back port to 7.x from #47701
Include `server.cors` configuration settings -- back port to 7.4 from #47701 [skip ci]
Include `server.cors` configuration settings -- back port to 7.x from #47701
Include `server.cors` configuration settings -- back port to 7.4 from #47701 [skip ci]
Summary
Include
server.corsconfiguration settings in the Kibana documentation. Closes #40095@KOTungseth FYI, this should be reviewed to ensure the defaults and descriptions are accurate.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.### For maintainers[skip ci]