Prepare TypeScript in data/visualizations plugin for 3.7#47678
Merged
timroes merged 1 commit intoelastic:masterfrom Oct 9, 2019
Merged
Prepare TypeScript in data/visualizations plugin for 3.7#47678timroes merged 1 commit intoelastic:masterfrom
timroes merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/kibana-app-arch (Team:AppArch) |
Contributor
💚 Build Succeeded |
timroes
pushed a commit
to timroes/kibana
that referenced
this pull request
Oct 9, 2019
timroes
pushed a commit
that referenced
this pull request
Oct 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a couple of issues in TypeScript, that will fail once we want to upgrade to 3.7.0 (#47188). TypeScript has fixed an issue where they allowed to have some imported type and exported type the same name, why those places would fail in TypeScript 3.7.0 (tested on my side).
The other place also throws an issue in TS 3.7.0 when compiling the Kibana types, if we don't specify the return type explicitly, so I added that too.
For QA
This PR doesn't contain any functional change.