[SIEM] Add tabbed sub-navigation to Network page#47556
[SIEM] Add tabbed sub-navigation to Network page#47556patrykkopycinski merged 9 commits intoelastic:masterfrom
Conversation
| const ip = decodeIpv6(detailName); | ||
| return indicesExistOrDataTemporarilyUnavailable(indicesExist) ? ( | ||
| <StickyContainer> | ||
| <GlobalTime> |
There was a problem hiding this comment.
moved GlobalTime here https://github.com/elastic/kibana/pull/47556/files#diff-837a0ad8db92736e389aba8d96e8d13cR27 to match structure from hosts
| {({ indicesExist, indexPattern }) => | ||
| indicesExistOrDataTemporarilyUnavailable(indicesExist) ? ( | ||
| <StickyContainer> | ||
| <GlobalTime> |
There was a problem hiding this comment.
moved GlobalTime here https://github.com/elastic/kibana/pull/47556/files#diff-837a0ad8db92736e389aba8d96e8d13cR27 to match structure from hosts
💔 Build Failed |
💔 Build Failed |
💚 Build Succeeded |
| <Route | ||
| path={`${networkPagePath}/:tabName(${NetworkTabType.ips})`} | ||
| render={() => ( | ||
| <ConditionalFlexGroup direction="column"> |
There was a problem hiding this comment.
Not sure if I considered all the cases, but I tried removing ConditionalFlexGroup here and seems to be ok.
<EuiFlexGroup>
<EuiFlexItem grow={1}>
<IPsQueryTabBody {...tabProps} flowTarget={FlowTargetNew.source} />
</EuiFlexItem>
<EuiFlexItem grow={1}>
<IPsQueryTabBody {...tabProps} flowTarget={FlowTargetNew.destination} />
</EuiFlexItem>
</EuiFlexGroup>
There was a problem hiding this comment.
I'm not sure, because on the bigger screen, I believe, we do have enough space to fit both tables in the same row, so I'd keep it as it's
There was a problem hiding this comment.
Sure, I’m happy to leave it as it is. Just want to make sure that the Kpi widget on the top of the page, which has a pretty similar layout, has the same behaviour. But let's keep the scope of this PR as it is an improve that later.
|
|
||
| <NetworkDnsQuery | ||
| endDate={to} | ||
| <NetworkTabs |
There was a problem hiding this comment.
Since that we've got a SiemNavigation component, what do you think if we rename this to something like NetworkTabsRoutes?
angorayc
left a comment
There was a problem hiding this comment.
Tested with IE11, left some optional change, beside that all good. Thanks a lot for applying tabs to network page!!
💚 Build Succeeded |
|
@elasticmachine merge upstream |
1 similar comment
|
@elasticmachine merge upstream |
💚 Build Succeeded |
💚 Build Succeeded |
|
@elasticmachine merge upstream |
💚 Build Succeeded |
|
Checked again for the tabs' order, good to merge! Thank you for making the change. |
|
Thank you so much @angorayc 👍 |
Summary
Implements tabbed sub-navigation to Network page #42461
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.- [ ] This was checked for cross-browser compatibility, including a check against IE11- [ ] Documentation was added for features that require explanation or tutorials- [ ] This was checked for keyboard-only and screenreader accessibilityFor maintainers
- [ ] This was checked for breaking API changes and was labeled appropriately- [ ] This includes a feature addition or change that requires a release note and was labeled appropriately