Skip to content

Honor current search criteria when exporting saved objects#47223

Merged
legrego merged 5 commits intoelastic:masterfrom
legrego:so/fix-filtered-export
Oct 7, 2019
Merged

Honor current search criteria when exporting saved objects#47223
legrego merged 5 commits intoelastic:masterfrom
legrego:so/fix-filtered-export

Conversation

@legrego
Copy link
Copy Markdown
Member

@legrego legrego commented Oct 3, 2019

Summary

Previously, the saved objects export UI would export all saved objects, rather than all saved objects which match the current on-screen search criteria.

This PR adds a new [optional] search parameter to the /api/saved_objects/_export API endpoint, which allows callers to provide a query string in addition to a types array. The client-side code was also updated to take advantage of this new search parameter.

Resolves #27250
Resolves #22590
Resolves #26236

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@elasticmachine

This comment has been minimized.

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Oct 3, 2019

Retest

@elasticmachine

This comment has been minimized.

@legrego legrego added release_note:fix Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.5.0 v8.0.0 labels Oct 4, 2019
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@legrego legrego marked this pull request as ready for review October 4, 2019 14:25
@legrego legrego requested a review from a team as a code owner October 4, 2019 14:25
@legrego legrego requested review from mikecote and rudolf October 4, 2019 14:25
Copy link
Copy Markdown
Contributor

@mikecote mikecote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, thanks for doing this 👍 Good to merge after @rudolf's review.

@elasticmachine

This comment has been minimized.

@legrego
Copy link
Copy Markdown
Member Author

legrego commented Oct 7, 2019

retest

@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

@legrego legrego merged commit dba0946 into elastic:master Oct 7, 2019
@legrego legrego deleted the so/fix-filtered-export branch October 7, 2019 14:11
legrego added a commit to legrego/kibana that referenced this pull request Oct 7, 2019
…7223)

* honor current search criteria when exporting saved objects

* adding core docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release_note:fix Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// v7.5.0 v8.0.0

Projects

None yet

5 participants