[Code] code viewer for APM integration by spacedragon · Pull Request #46884 · elastic/kibana

spacedragon · 2019-09-29T09:45:52Z

Summary

https://github.com/elastic/code/issues/1634

Checklist

Use ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.

This was checked for cross-browser compatibility, including a check against IE11
Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
Documentation was added for features that require explanation or tutorials
Unit or functional tests were updated or added to match the most common scenarios
This was checked for keyboard-only and screenreader accessibility

For maintainers

This was checked for breaking API changes and was labeled appropriately
This includes a feature addition or change that requires a release note and was labeled appropriately

elasticmachine · 2019-09-29T10:56:12Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-29T13:31:37Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request

elasticmachine · 2019-09-30T22:02:41Z

Pinging @elastic/code

spacedragon · 2019-10-02T09:28:50Z

@elasticmachine merge upstream

elasticmachine · 2019-10-08T04:08:42Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 208ad82693c13b7eb0ed8d90ca493b9331d814f9

spacedragon · 2019-10-10T01:44:56Z

@elasticmachine merge upstream

elasticmachine · 2019-10-10T02:51:57Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 4b75afb83c68e939421c20bcf785c1e23ca9618c

mw-ding

This is awesome!

Can you move all the core components to this fold https://github.com/elastic/kibana/tree/master/x-pack/legacy/plugins/code/public/components/integrations. The apm_demo folder has been removed.

@rylnd can you take look at this PR in case some of the conventions are not aligned.

spacedragon · 2019-10-11T07:08:26Z

This is awesome!

Can you move all the core components to this fold https://github.com/elastic/kibana/tree/master/x-pack/legacy/plugins/code/public/components/integrations. The apm_demo folder has been removed.

done

spacedragon · 2019-10-11T09:19:11Z

retest

spacedragon · 2019-10-11T14:08:59Z

retest

elasticmachine · 2019-10-11T15:22:17Z

💔 Build Failed

continuous-integration/kibana-ci/pull-request
Commit: 81b4041

rylnd · 2019-10-15T23:30:03Z

@spacedragon there's a small conflict due to my data changes in #48230, as we discussed. Let me know if you need help resolving it.

rylnd · 2019-10-16T20:59:26Z

x-pack/legacy/plugins/code/public/components/integrations/code_flyout_main.tsx

+        <div className="codeFlyout__header--file">
+          <EuiIcon type="codeApp" size="m" />
+          <EuiText size="s">
+            <EuiLink href={`/app/code#/${props.repo}/blob/${props.revision}/${props.file}`}>


@spacedragon I don't think this is generating the correct route, at least not in dev mode (the three-letter path prefix is lost)

Hmm, it works on my machine. What url did it give you there?
We can fire an issue after merge this PR if there is a problem.

* Do not nest classes unless necessary (none here were needed) * Prefer to give an EUI component a class rather than styling its internal one * use underscores to separate blocks from elements

This is a less unexpected way to align our tabs on the right.

The ID was removed when we switched to a ref, and I did not see a need for the flex-grow declarations.

The subtree is going to be redrawn either way; saving the one outer div here isn't adding much.

spacedragon · 2019-10-18T01:28:34Z

@spacedragon there's a small conflict due to my data changes in #48230, as we discussed. Let me know if you need help resolving it.

No worries, problem solved, thanks .

elasticmachine · 2019-10-18T03:05:30Z

💚 Build Succeeded

continuous-integration/kibana-ci/pull-request
Commit: 1c20ac1

* [Code] code viewer for APM integration

spacedragon requested a review from mw-ding September 29, 2019 09:46

spacedragon force-pushed the apm_codebrowser branch from 5a171d7 to 78809dd Compare September 29, 2019 12:25

mw-ding added the Team:Code label Sep 30, 2019

mw-ding requested a review from rylnd September 30, 2019 22:02

spacedragon force-pushed the apm_codebrowser branch 2 times, most recently from 6d2c46d to ccc0049 Compare October 8, 2019 02:19

spacedragon marked this pull request as ready for review October 8, 2019 02:20

spacedragon requested a review from a team as a code owner October 8, 2019 02:20

spacedragon added release_note:enhancement v7.6.0 v8.0.0 labels Oct 8, 2019

spacedragon force-pushed the apm_codebrowser branch from ccc0049 to 208ad82 Compare October 8, 2019 03:00

elastic deleted a comment from elasticmachine Oct 8, 2019

mw-ding reviewed Oct 10, 2019

View reviewed changes

spacedragon force-pushed the apm_codebrowser branch from 4b75afb to 81b4041 Compare October 11, 2019 07:08

spacedragon requested a review from a team as a code owner October 11, 2019 07:08

elastic deleted a comment from elasticmachine Oct 11, 2019

rylnd reviewed Oct 16, 2019

View reviewed changes

spacedragon and others added 13 commits October 18, 2019 09:19

[Code] code viewer for APM integration

d79fa77

Refactoring css class names.

904abf4

Missed one.

55ac0f3

[Code] code viewer for APM integration

b96c5ec

[Code] fix diff api

a7ae603

Clean up CodeFlyout CSS classes

a91c7d3

* Do not nest classes unless necessary (none here were needed) * Prefer to give an EUI component a class rather than styling its internal one * use underscores to separate blocks from elements

Prefer CSS rules to style DOM elements

e2e14d8

Use justify-content instead of flipping element order

c4bba2a

This is a less unexpected way to align our tabs on the right.

Remove unnecessary styles and selectors

236c22f

The ID was removed when we switched to a ref, and I did not see a need for the flex-grow declarations.

Return no element if the flyout is hidden

aa96a76

The subtree is going to be redrawn either way; saving the one outer div here isn't adding much.

Prefer CSS class to inline styles

a95497a

Prefer instance members to constructor assignments

c8948d7

Center fileHeader vertically within subHeader

74fed54

[Code] merged code from ryland

1c20ac1

spacedragon force-pushed the apm_codebrowser branch from e9be424 to 1c20ac1 Compare October 18, 2019 01:45

daveyholler self-requested a review October 18, 2019 02:07

daveyholler approved these changes Oct 18, 2019

View reviewed changes

spacedragon merged commit e3bce65 into elastic:master Oct 18, 2019

spacedragon deleted the apm_codebrowser branch October 18, 2019 03:27

spacedragon mentioned this pull request Oct 18, 2019

[7.x] [Code] code viewer for APM integration (#46884) #48600

Merged

spacedragon pushed a commit to spacedragon/kibana that referenced this pull request Oct 18, 2019

[Code] code viewer for APM integration (elastic#46884)

b4ae719

* [Code] code viewer for APM integration

spacedragon pushed a commit to spacedragon/kibana that referenced this pull request Oct 18, 2019

[Code] code viewer for APM integration (elastic#46884)

7ec8d33

* [Code] code viewer for APM integration

spacedragon mentioned this pull request Oct 18, 2019

[7.5] [Code] code viewer for APM integration (#46884) #48601

Merged

spacedragon pushed a commit that referenced this pull request Oct 18, 2019

[Code] code viewer for APM integration (#46884) (#48601)

5a445d5

* [Code] code viewer for APM integration

spacedragon pushed a commit that referenced this pull request Oct 18, 2019

[Code] code viewer for APM integration (#46884) (#48600)

41c8234

* [Code] code viewer for APM integration

Conversation

spacedragon commented Sep 29, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Sep 29, 2019

💔 Build Failed

Uh oh!

elasticmachine commented Sep 29, 2019

💚 Build Succeeded

Uh oh!

elasticmachine commented Sep 30, 2019

Uh oh!

spacedragon commented Oct 2, 2019

Uh oh!

elasticmachine commented Oct 8, 2019

💚 Build Succeeded

Uh oh!

spacedragon commented Oct 10, 2019

Uh oh!

elasticmachine commented Oct 10, 2019

💚 Build Succeeded

Uh oh!

mw-ding left a comment

Choose a reason for hiding this comment

Uh oh!

spacedragon commented Oct 11, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

spacedragon commented Oct 11, 2019

Uh oh!

spacedragon commented Oct 11, 2019

Uh oh!

elasticmachine commented Oct 11, 2019

💔 Build Failed

Uh oh!

rylnd commented Oct 15, 2019

Uh oh!

rylnd Oct 16, 2019

Choose a reason for hiding this comment

Uh oh!

spacedragon Oct 18, 2019

Choose a reason for hiding this comment

Uh oh!

spacedragon commented Oct 18, 2019

Uh oh!

elasticmachine commented Oct 18, 2019

💚 Build Succeeded

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

spacedragon commented Sep 29, 2019 •

edited

Loading

spacedragon commented Oct 11, 2019 •

edited

Loading