Re-split ciGroups after pipeline rollout#46375
Merged
spalger merged 6 commits intoelastic:masterfrom Sep 25, 2019
Merged
Conversation
Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)" This reverts commit b1a01ef.
Contributor
💚 Build Succeeded |
spalger
reviewed
Sep 23, 2019
Contributor
Author
|
I'm looking at x-pack ciGroup8, because it's really slow and is keeping the run time pretty high. It's primarily the spaces api integration tests. They are taking about 2/3 of the time spent in ciGroup8. Worst-case scenario, we could probably add an x-pack parallel worker or two (without adding machines), but I'm seeing if there's anything else we might be able to do. Those tests are generally pretty quick, but there's so many of them, most of the time is spent in setup/teardown. |
Contributor
|
The only other option I can imagine is to split the tests up and put them in existing ciGroups (I prefer giving them their own ciGroup assuming we're not already at the edge of capacity) Some low times:
|
Contributor
💚 Build Succeeded |
…I faster" This reverts commit 1213239.
Contributor
💚 Build Succeeded |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded |
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 25, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 25, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 25, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around # Conflicts: # x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/index.ts # x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js # x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts # x-pack/test/pki_api_integration/apis/index.ts # x-pack/test/visual_regression/tests/maps/index.js
spalger
pushed a commit
to spalger/kibana
that referenced
this pull request
Sep 25, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (elastic#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (elastic#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around # Conflicts: # .ci/jobs.yml # .ci/run.sh # Jenkinsfile # test/functional/apps/visualize/index.ts # test/mocha_decorations.d.ts # test/scripts/jenkins_firefox_smoke.sh # test/scripts/jenkins_xpack_ci_group.sh # test/scripts/jenkins_xpack_firefox_smoke.sh # x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/index.ts # x-pack/test/api_integration/apis/index.js # x-pack/test/api_integration/apis/spaces/index.ts # x-pack/test/functional/apps/apm/index.ts # x-pack/test/functional/apps/dashboard_mode/index.js # x-pack/test/functional/apps/index_lifecycle_management/index.ts # x-pack/test/functional/apps/infra/index.ts # x-pack/test/functional/apps/license_management/index.ts # x-pack/test/functional/apps/maps/index.js # x-pack/test/functional/apps/uptime/index.ts # x-pack/test/kerberos_api_integration/apis/index.ts # x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js # x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts # x-pack/test/pki_api_integration/apis/index.ts # x-pack/test/saved_object_api_integration/security_only/apis/index.ts # x-pack/test/spaces_api_integration/security_and_spaces/apis/index.ts # x-pack/test/ui_capabilities/security_and_spaces/tests/index.ts # x-pack/test/ui_capabilities/security_only/tests/index.ts # x-pack/test/ui_capabilities/spaces_only/tests/index.ts # x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.js # x-pack/test/visual_regression/tests/maps/index.js
spalger
pushed a commit
that referenced
this pull request
Sep 25, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around # Conflicts: # x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/index.ts # x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js # x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts # x-pack/test/pki_api_integration/apis/index.ts # x-pack/test/visual_regression/tests/maps/index.js
spalger
pushed a commit
that referenced
this pull request
Sep 26, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around
spalger
pushed a commit
that referenced
this pull request
Sep 26, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around
spalger
pushed a commit
that referenced
this pull request
Sep 26, 2019
* Re-split ciGroups after pipeline rollout Revert "Revert "Revert "Revert "Revert "[ci] compress jobs for CI stab… (#45454)" This reverts commit 9a109f2. Revert "set IS_PIPELINE_JOB in intake jobs (#45850)" This reverts commit b1a01ef. * Split one of the slow test suites up to try to make overall CI faster * Disable visualRegression groups, they are being handled in other work * Revert "Split one of the slow test suites up to try to make overall CI faster" This reverts commit 1213239. * Move some different xpack ciGroup8 suites around # Conflicts: # .ci/jobs.yml # .ci/run.sh # Jenkinsfile # test/functional/apps/visualize/index.ts # test/mocha_decorations.d.ts # test/scripts/jenkins_firefox_smoke.sh # test/scripts/jenkins_xpack_ci_group.sh # test/scripts/jenkins_xpack_firefox_smoke.sh # x-pack/test/alerting_api_integration/security_and_spaces/tests/index.ts # x-pack/test/alerting_api_integration/spaces_only/tests/index.ts # x-pack/test/api_integration/apis/index.js # x-pack/test/api_integration/apis/spaces/index.ts # x-pack/test/functional/apps/apm/index.ts # x-pack/test/functional/apps/dashboard_mode/index.js # x-pack/test/functional/apps/index_lifecycle_management/index.ts # x-pack/test/functional/apps/infra/index.ts # x-pack/test/functional/apps/license_management/index.ts # x-pack/test/functional/apps/maps/index.js # x-pack/test/functional/apps/uptime/index.ts # x-pack/test/kerberos_api_integration/apis/index.ts # x-pack/test/oidc_api_integration/apis/authorization_code_flow/index.js # x-pack/test/oidc_api_integration/apis/implicit_flow/index.ts # x-pack/test/pki_api_integration/apis/index.ts # x-pack/test/saved_object_api_integration/security_only/apis/index.ts # x-pack/test/spaces_api_integration/security_and_spaces/apis/index.ts # x-pack/test/ui_capabilities/security_and_spaces/tests/index.ts # x-pack/test/ui_capabilities/security_only/tests/index.ts # x-pack/test/ui_capabilities/spaces_only/tests/index.ts # x-pack/test/upgrade_assistant_integration/upgrade_assistant/index.js # x-pack/test/visual_regression/tests/maps/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ciGroups were combined to cut down on the number of Jenkins workers we needed per build. Now that pipelines are rolled out, we can split them back out without increasing the number of workers.