[Uptime] Improve UI tests and platform#46269
Merged
justinkambic merged 33 commits intoelastic:masterfrom Oct 9, 2019
Merged
Conversation
Contributor
|
Pinging @elastic/uptime |
Contributor
💔 Build Failed |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed |
Contributor
Author
|
@spalger I'm not fully understanding the error messages I'm seeing but it seems like most of the tests aren't running. |
Contributor
💔 Build Failed |
7 tasks
Contributor
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded40 successful executions |
Contributor
|
@elasticmachine merge upstream |
Contributor
💔 Build Failed40 successful executions, flaky failure #43736 |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded40 successful executions |
added 2 commits
October 9, 2019 09:33
spalger
approved these changes
Oct 9, 2019
Contributor
spalger
left a comment
There was a problem hiding this comment.
120 successful runs, LGTM!
Contributor
💚 Build Succeeded |
justinkambic
added a commit
to justinkambic/kibana
that referenced
this pull request
Oct 9, 2019
* Remove depdency on legacy interface. * Remove custom interface, use common breadcrumb type. * Add HTML template for app react entry point. * Update app props. * Add constant for react app entry point. * Remove dependency on legacy capabilities provider. * Delete legacy kibana framework adapter. * Add New Platform adapter, reference in startup code. * Remove dependency on legacy capabilities function. * Delete reference to obsolete interface. * Fix busted types in new adapter. * Add new plugin class, delete old bootstrap code. * Update routing/functional tests. * Provide default for potentially-undefined value. * run x-pack-ciGroup6 40 times * Reinsert firefox skip tag. * Update functional tests to work with newly-merged fixtures. * Revert "run x-pack-ciGroup6 40 times" This reverts commit ac3b1e4.
justinkambic
added a commit
that referenced
this pull request
Oct 14, 2019
* Remove depdency on legacy interface. * Remove custom interface, use common breadcrumb type. * Add HTML template for app react entry point. * Update app props. * Add constant for react app entry point. * Remove dependency on legacy capabilities provider. * Delete legacy kibana framework adapter. * Add New Platform adapter, reference in startup code. * Remove dependency on legacy capabilities function. * Delete reference to obsolete interface. * Fix busted types in new adapter. * Add new plugin class, delete old bootstrap code. * Update routing/functional tests. * Provide default for potentially-undefined value. * run x-pack-ciGroup6 40 times * Reinsert firefox skip tag. * Update functional tests to work with newly-merged fixtures. * Revert "run x-pack-ciGroup6 40 times" This reverts commit ac3b1e4.
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not review before #44722 is merged.Resolves #46245.
For some time now Uptime's UI tests have not been running because of routing difficulties and flaky behavior. This patch seeks to update the way the app routes and re-enable several tests that have been skipped until now.
The success criteria for this change is that it will be easy for us to add additional functional tests in the future as we introduce new features.
Checklist
Use
strikethroughsto remove checklist items you don't feel are applicable to this PR.For maintainers