Merged
Conversation
convert format changing to match date_range
Contributor
|
LGTM, sending to @w33ble for second looks. |
Contributor
There was a problem hiding this comment.
This should either start with an open paren ( or end with a close square bracket ].
Right now it displays as [2kB, 4kB), but (2kB, 4kB) or [2kB, 4kB] seems more correct. You'll need to update the tests too.
Contributor
|
Other than the one change, this LGTM. Feel free to merge after the fix. |
This was referenced Aug 28, 2015
Closed
w33ble
added a commit
to w33ble/kibana
that referenced
this pull request
Sep 2, 2015
Merged
This was referenced Sep 15, 2015
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4404
This change adds better support for formatting ranges in places like:
tooltips:
the filter bar:
and the legend:
the changes started with #4434 and during review expanded into this PR.