Remove index lifecycle phase filter from Index Management #45486
Merged
cjcenizal merged 1 commit intoelastic:masterfrom Sep 12, 2019
Merged
Remove index lifecycle phase filter from Index Management #45486cjcenizal merged 1 commit intoelastic:masterfrom
cjcenizal merged 1 commit intoelastic:masterfrom
Conversation
Contributor
|
Pinging @elastic/es-ui |
… ES API doesn't provide the required information for us to implement the expected behavior.
b64f7fe to
5e81596
Compare
Contributor
💚 Build Succeeded |
alisonelizabeth
approved these changes
Sep 12, 2019
Contributor
alisonelizabeth
left a comment
There was a problem hiding this comment.
Code LGTM. Did not test locally.
| "xpack.watcher.watcherDescription": "アラートの作成、管理、監視によりデータへの変更を検知します。" | ||
| } | ||
| } | ||
| } No newline at end of file |
Contributor
There was a problem hiding this comment.
nit: add back newline
Contributor
Author
There was a problem hiding this comment.
This was a result of running node scripts/i18n_check --fix so I'm inclined to leave it in. Seems like something we should change in the tool itself.
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Sep 12, 2019
… ES API doesn't provide the required information for us to implement the expected behavior. (elastic#45486)
cjcenizal
added a commit
to cjcenizal/kibana
that referenced
this pull request
Feb 11, 2020
cjcenizal
added a commit
that referenced
this pull request
Feb 20, 2020
cjcenizal
added a commit
that referenced
this pull request
Feb 21, 2020
jloleysens
added a commit
to jloleysens/kibana
that referenced
this pull request
Feb 21, 2020
…-out-of-legacy * 'master' of github.com:elastic/kibana: (109 commits) document difference between log record formats (elastic#57798) Expose elasticsearch config schema (elastic#57655) [ui/agg_response/tabify] update types for search/expressions/build_tabular_inspector_data.ts (elastic#58130) [SIEM] Cleans Cypress tests code (elastic#58134) fix: 🐛 make dev server Storybook builds work again (elastic#58188) Prevent core savedObjects plugin from being overridden (elastic#58193) Expose serverBasePath on client-side (elastic#58070) Fix legend sizing on area charts (elastic#58083) Drilldown plugin (elastic#58097) [skip-ci] Fix broken links to saved objects APIs in MIGRATION.md (elastic#58033) [ML] New Platform server shim: update datafeed routes (elastic#57739) Add flag for building static storybook site (elastic#58050) add monaco to kbn/ui-shared-deps and load required features for all uses (elastic#58075) [SIEM] Let us try out code owners for a little while and see what happens Add throttle param to Alerting readme (elastic#57609) [NP] Move ui/saved_objects to NP (elastic#57452) [Logs UI] Fix column reordering in settings page (elastic#58104) Fix browser date format (elastic#57714) Add filter for ILM phase to Index Management (revert elastic#45486) (elastic#57402) Clarify Precision function in Timelion Kibana (elastic#58031) ... # Conflicts: # x-pack/.i18nrc.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45484
Per discussion in elastic/elasticsearch#46357, this filter implies that you can filter down to indices that are in a particular phase. However, the ES API doesn't currently provide the information needed to do that. Because this filter causes confusion among users, we're removing it until we can implement the desired behavior.
Before
After